migrate\Plugin\migrate\id_map\Sql assumes a PDO db driver

Added a new exception (database independent), and changed Sql to use Connection::exceptionHandler that throws the new exception.

I'd like to add @group Database tests for the new exceptions.

Added tests to mysql's SchemaTest

We need a change record for the new exceptions. Also the IS needs to be updated for the new exceptions.

Updated IS

CR drafted, https://www.drupal.org/node/3389316 →

Can we add testing for PostgreSQL and SQLite.

The maximum character length for a text field in PostgreSQL is 10485760. See: https://www.postgresql.org/docs/current/datatype-character.html

The maximum character length for a text field in SQLite is 1 billion. See: https://www.sqlite.org/limits.html

The maximum number of columns in an index in PostgreSQL is 32. See: https://www.postgresql.org/docs/current/limits.html

The maximum number of columns in an index in SQLite is 2000. See: https://www.sqlite.org/limits.html

I suggest to do #10 in a follow up.

I bet it just needs to extend existing tests for pgsql and sqlite like it was done for mysql

Well not extend, they have to be written specifically for each database since each database has different limitations, see #10.

One may argue that a test creating a table with over 2000 columns (sqlite) to trigger the failure is overkill. That’s why I suggest to do that in separate issues where each database tests can be discussed separately.

The blocker tag is only relevant for mysqli implementation.

@mondrake Thanks for explanation, it makes sense!

Moreover there's existing follow-up 📌 Forbid limited length primary and unique keys, allow only in indexes Needs work

All code changes look good.
The IS and the CR are in order.
The testing for PostgreSQL and SQLite will be done in a followup.
For me it is RTBC.

Filed followups for PostgreSQL and SQLite.

Very tidy, just adding a more explicit exception instead of relying on the exception message.

Committed df59482 and pushed to 11.x. Thanks!

mondrake → closed merge request !4855

Automatically closed - issue fixed for 2 weeks with no activity.