Support admin theme logo

Duplicate of 🌱 Define logo origin on the Toolbar Active , that is worth reading too. Since you have code here, I'll close that one and carry over credits here.

Gábor Hojtsy → credited ckrina → .

Gábor Hojtsy → credited DieterHolvoet → .

Gábor Hojtsy → credited jwilson3 → .

Gábor Hojtsy → credited mherchel → .

I don't think Claro should be the source for the admin logo, I wouldn't tie this to a theme (Claro in here) because it forces people using the Toolbar with Claro. It'd tie it to a configuration for the admin itself.

@ckrina

I wouldn't tie this to a theme (Claro in here)

It doesn't tie it to Claro. It uses whatever admin theme is set.

it forces people using the Toolbar with Claro

It doesn't force people using the toolbar either. It just uses the logo set in the default admin theme. If that's not the go to place we might want to remove that setting altogether for admin themes as it has no purpose.

Still, I don't think this info should live in the theme settings as discussed in yesterday's meeting.

I also think it needs to go through the image style process so it looks and loads quickly.

(by @mherchel)
Agreed on this being a need too.

What I'm currently missing is an easy way to provide a site-specific SVG logo that can consider dark/light mode.
(by @DieterHolvoet)
We also discussed this yesterday, and agreed to postpone this until after MVP because of the several implications on a complexity and security levels.

(by @DieterHolvoet)
We also discussed this yesterday, and agreed to postpone this until after MVP because of the several implications on a complexity and security levels.

In the implementation in Gin we provide an drupal.svg which we use as default via CSS mask-image to support darkmode out of the box.

If a custom logo is set in Gin's theme settings we'll use that instead.

That's how we handle it currently with the toolbar and also with the experimental navigation I've implemented a few days ago in the dev branch for testing purposes (maybe as inspiration):

Accent color:

Darkmode accent color:

Custom logo:

This is independent of where the custom logo will be stored (global setting or on the admin theme settings).

Discussed at DrupalCon Lille: we need to move this into a specific form for the admin UI still to be defined, not just as something tied to the admin theme. But meanwhile let's support this feature inside the theme so Gin can use it.

This needs a rebase though.

Rebased

Thanks! This has been merged.

Automatically closed - issue fixed for 2 weeks with no activity.