Fix return type in \Drupal\Tests\rest\Functional\ResourceTestBase::recursiveKSort()

The changes look ok go go ahead with.
The MR pipeline was giving error most likely because it needed to be rebased, rebased and now it all looks ok (didnt realize that rebasing will add a comment in this thread too as a new MR)
RTBC +1 from my side, cant do it myself as I got 1 MR added.

Change is simple enough. Also think this would of been a good one to tag for new users.

Hmm, #3283794: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code → is interesting and seems a lot could have been the wrong way around. I think it's more common to have incorrect return docs than incorrect return values.

The diffstat for the previous issue (excluding the baseline regeneration) was +192, -85 -- 277 total lines to review, so already above our recommended 100-200 and in the range that should be reserved for change sets that are scannable without context. That issue definitely is not scannable without context because you need to look up whole methods, callers, parent implementations, etc. to determine whether adding a return type or removing the docs is the correct approach, and what the type should be.

For example, for this issue, I had to do:

grep -rl "recursiveKSort" *

...then open all those files and check how the method was used to see if they relied on the return value or the pass-by-reference. In all cases they relied on the pass-by-reference and did not expect a return value.

So this issue is fine, and committable by itself. However, can we first get a followup to check over #3283794: Fix 'should return {type} but return statement is missing' PHPStan L0 errors in test code → and ensure we didn't introduce any other incorrect return values?

And in the future, such issues should be split into smaller logical scopes.

Saving credits.

Follow up made, 📌 Check returns values added in #3283794 Active

Committed and pushed 321492b8a8 to 11.x and 9164d2f354 to 10.2.x and 946c240fe7 to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.