- Issue created by @Shreya_98
- @shreya_th opened merge request.
- 🇮🇳India Shreya_98
Hi @yogesh.k,
I have created MR for Drupal Coding Standards Issues .Kindly review the changes.Thank you.
- Status changed to Needs work
over 1 year ago 2:07pm 18 September 2023 - 🇹🇷Turkey orkut murat yılmaz Istanbul
@Shreya_th, thanks for your fast contribution. The other 2 files look nice, but the change you've made on revolt.theme file is not a good practice. Maybe there could be a better way for getting rid of that warning, than commenting out the line.
Best,
Orkut - 🇮🇳India Shreya_98
Yes @Orkut Murat Yilmaz i will make change in revolt.theme file asap.
Thank you
- 🇺🇦Ukraine paulrad
@Shreya_th, this hook isn't used so you could just remove lines 199-205.
- Status changed to Needs review
over 1 year ago 4:58am 19 September 2023 - 🇮🇳India Shreya_98
Hi everyone,
I have done the changes told by @paulrad . Kindly review the changes .Thank you.
- Status changed to RTBC
over 1 year ago 7:15am 20 September 2023 - 🇮🇳India sarwan_verma
Hi everyone, I have tested the MR and it fixes the issue. Moving it to the RTBC.
- Status changed to Needs review
over 1 year ago 7:24am 20 September 2023 - 🇮🇳India abhiyanshu
@Shreya_th,
"I have carefully reviewed your changes and found that the code is running smoothly for three of the files. However, there is still one lingering linting error in the views-mini-pager.html.twig file.
I've taken the liberty to address this issue and have created a patch to rectify it.(Please refer to the attached patch)With the fix in place, I'm now moving this to the 'RTBC' (Reviewed and Tested by the Community), Thank you.
- Status changed to RTBC
over 1 year ago 9:52am 20 September 2023 - 🇮🇳India Shreya_98
@abhiyanshu_rawat ,
Thank you for pointing out the issue , I have applied your patch and it is running successfully. I have added your patch changes and raised the PR. Please review and verify. - First commit to issue fork.
-
pkghang →
committed fe12d670 on 1.0.x authored by
Shreya_th →
Issue #3387977 by Shreya_th, abhiyanshu_rawat, yogesh.k, Orkut Murat...
-
pkghang →
committed fe12d670 on 1.0.x authored by
Shreya_th →
- Status changed to Fixed
over 1 year ago 10:30am 20 September 2023 - Status changed to Downport
over 1 year ago 11:00am 20 September 2023 - 🇹🇷Turkey orkut murat yılmaz Istanbul
It would be better to create a new release, after merging is done. Please check this documentation → .
Best,
Orkut - Status changed to Fixed
over 1 year ago 12:17pm 20 September 2023 - Status changed to Fixed
about 1 year ago 5:58am 29 September 2023 - Status changed to Fixed
about 1 year ago 9:26am 4 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.