Contrib.social

Views' config schema should not consider fallback plugin IDs as valid

Open on Drupal.org →
Created on 14 September 2023, over 1 year ago

Problem/Motivation

This was discovered while working on 📌 Adopt PluginExists validator in relevant places RTBC .

It turns out that there are a good number of views in core (mostly test views, but some are part of modules' shipped config) that reference invalid handler plugin IDs. Apparently these are converted to supported plugin IDs at runtime (or install time? I'm not really sure), but that still means the config we're shipping is invalid.

At the moment, the only reason tests don't fail is because we are allowing Views config schema to accept invalid plugin IDs, and considering the fallback plugin IDs as valid, just so we don't have to fix all those views in 📌 Adopt PluginExists validator in relevant places RTBC . That work should be done in a separate scope (this issue).

Steps to reproduce

If you remove the allowFallback: true lines from Views' config schema, you'll start to get test failures due to various views using invalid handler plugin IDs.

Proposed resolution

Remove all of the allowFallback: true lines and fix the views which cause trouble.

Remaining tasks

Do that, and commit it.

🐛 Bug report
Status

Active

Version

11.0 🔥

Component
Views  →

Last updated 3 minutes ago

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Status changed to Postponed over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment over 1 year ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Status changed to Active about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States phenaproxima Massachusetts

    Blocker is in.

  • Merge request !6526Let slip the dogs of war! → (Open) created by phenaproxima
  • Pipeline finished with Failed
    about 1 year ago
    Total: 522s
    #91294
  • Pipeline finished with Failed
    about 1 year ago
    Total: 560s
    #91378
  • Pipeline finished with Failed
    about 1 year ago
    Total: 462s
    #91389
  • Pipeline finished with Failed
    about 1 year ago
    Total: 663s
    #91401
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States phenaproxima Massachusetts

    Okay, I got the ball rolling here by fixing (I think) nearly all of the kernel tests. Functional tests are probably still going to fail. But I think what I have already got is a good start for someone else to pick up.

  • Pipeline finished with Failed
    about 1 year ago
    Total: 482s
    #91429
  • Pipeline finished with Failed
    about 1 year ago
    Total: 583s
    #91655
  • First commit to issue fork.
  • Pipeline finished with Failed
    12 days ago
    Total: 872s
    #471954
  • Pipeline finished with Running
    11 days ago
    #472262
  • Pipeline finished with Failed
    11 days ago
    Total: 167s
    #472275
  • Pipeline finished with Failed
    11 days ago
    Total: 616s
    #472276
  • Pipeline finished with Canceled
    11 days ago
    Total: 95s
    #472301
  • Pipeline finished with Failed
    11 days ago
    Total: 570s
    #472302
  • Pipeline finished with Canceled
    11 days ago
    Total: 84s
    #472313
  • Pipeline finished with Canceled
    11 days ago
    #472314
  • Pipeline finished with Canceled
    11 days ago
    Total: 184s
    #472315
  • Pipeline finished with Success
    11 days ago
    #472317
  • Comment 11 days ago →
    🇳🇱Netherlands bbrala Netherlands

    All green.

    1. Skip validation on an intentional broken view.
    2. Fix multiple views where plugins were not existing.
    3. Adjust one test which seemed reasonable to have that as output. Think that is no BC

    Think this is good to go.

  • Comment 11 days ago →
    🇺🇸United States smustgrave

    Searched for allowFallback: true in views and all 6 instances appear to be addressed.

    Assuming if any views were missed they would of got picked up, so assuming this is good to go

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024