Views' config schema should not consider fallback plugin IDs as valid

Created on 14 September 2023, about 1 year ago
Updated 9 February 2024, 10 months ago

Problem/Motivation

This was discovered while working on πŸ“Œ Adopt PluginExists validator in relevant places RTBC .

It turns out that there are a good number of views in core (mostly test views, but some are part of modules' shipped config) that reference invalid handler plugin IDs. Apparently these are converted to supported plugin IDs at runtime (or install time? I'm not really sure), but that still means the config we're shipping is invalid.

At the moment, the only reason tests don't fail is because we are allowing Views config schema to accept invalid plugin IDs, and considering the fallback plugin IDs as valid, just so we don't have to fix all those views in πŸ“Œ Adopt PluginExists validator in relevant places RTBC . That work should be done in a separate scope (this issue).

Steps to reproduce

If you remove the allowFallback: true lines from Views' config schema, you'll start to get test failures due to various views using invalid handler plugin IDs.

Proposed resolution

Remove all of the allowFallback: true lines and fix the views which cause trouble.

Remaining tasks

Do that, and commit it.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
ViewsΒ  β†’

Last updated about 12 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Status changed to Postponed 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί
  • Status changed to Active 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Blocker is in.

  • Merge request !6526Let slip the dogs of war! β†’ (Open) created by phenaproxima
  • Pipeline finished with Failed
    10 months ago
    Total: 522s
    #91294
  • Pipeline finished with Failed
    10 months ago
    Total: 560s
    #91378
  • Pipeline finished with Failed
    10 months ago
    Total: 462s
    #91389
  • Pipeline finished with Failed
    10 months ago
    Total: 663s
    #91401
  • Status changed to Needs work 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Okay, I got the ball rolling here by fixing (I think) nearly all of the kernel tests. Functional tests are probably still going to fail. But I think what I have already got is a good start for someone else to pick up.

  • Pipeline finished with Failed
    10 months ago
    Total: 482s
    #91429
  • Pipeline finished with Failed
    10 months ago
    Total: 583s
    #91655
Production build 0.71.5 2024