- Issue created by @fjgarlin
- Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @fjgarlin opened merge request.
- last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 10:13am 8 September 2023 - Status changed to Needs work
over 1 year ago 10:17am 8 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Well, at least it caught some valid typos :)
/var/www/html/.gitlab-ci.yml:28:19 - Unknown word (overriden) /var/www/html/.gitlab-ci.yml:70:91 - Unknown word (worfklows) /var/www/html/.gitlab-ci/pipeline.yml:8:9 - Unknown word (Selectig) /var/www/html/.gitlab-ci/pipeline.yml:10:61 - Unknown word (druaplci)
The others need adding to the dictionary.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 30,144 pass, 1 fail - last update
over 1 year ago 30,144 pass, 1 fail - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - ๐ฌ๐งUnited Kingdom longwave UK
We should wrap all comments at 80 characters in the YAML files to match our standards.
- ๐ฌ๐งUnited Kingdom catch
This is critical for core test performance and also for Drupal.org gitlab migration, so bumping priority.
Happy to commit this as soon as the comment feedback above is cleaned up and then we can keep going in other issues, and figure out exactly which bits of DrupalCI to switch off.
- ๐ช๐ธSpain fjgarlin
There has been really good progress here: ๐ [PP-1] Reduce test pipeline times to around 18 minutes and always report back unit tests Closed: duplicate
We are getting total run times of less than 20 minutes now.I've suggested that those changes be merged here so we have only one source of truth to review for GitlabCI integration.
- last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - ๐ฎ๐ฉIndonesia el7cosmos ๐ฎ๐ฉ GMT+7
larowlan โ credited el7cosmos โ .
- ๐ณ๐ฟNew Zealand xurizaemon ลtepoti, Aotearoa ๐
larowlan โ credited xurizaemon โ .
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Crediting those who worked in the sandbox
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
And those who helped at Drupal south code sprint
- last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,134 pass, 2 fail - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - ๐ฌ๐งUnited Kingdom catch
Two more nits on the MR, for me the only thing blocking commit of this is the nightwatch failures which seem pretty consistent.
- last update
over 1 year ago Build Successful - last update
over 1 year ago 30,146 pass - Status changed to Needs review
over 1 year ago 1:07pm 11 September 2023 - ๐ช๐ธSpain fjgarlin
the only thing blocking commit of this is the nightwatch failures
Fixed.
- last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
larowlan โ credited alexpott โ .
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Crediting alex who also worked in the sandbox
- Status changed to Needs work
over 1 year ago 10:55pm 11 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Thanks for working on this, this is looking really good. Added some questions and comments, some of which can be dealt with in followups.
- last update
over 1 year ago 30,148 pass - last update
over 1 year ago CI aborted - last update
over 1 year ago 30,148 pass - last update
over 1 year ago 30,148 pass - last update
over 1 year ago 30,148 pass - ๐ธ๐ฐSlovakia poker10
Added few very minor nits regarding comments/whitespaces to the MR.
- last update
over 1 year ago 30,146 pass, 1 fail 30:05 4:05 Running- Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8
13:00 13:00 Queueing - last update
over 1 year ago 30,124 pass, 2 fail - Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 30,148 pass 47:50 19:55 Running- ๐ฌ๐งUnited Kingdom catch
Last commit results in
CSpell: Files checked: 1, Issues found: 0 in 0 files
which should be correct I think. - Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 30,148 pass - Status changed to Needs review
over 1 year ago 7:20pm 12 September 2023 - ๐ฌ๐งUnited Kingdom catch
I think that is probably all feedback resolved. Opened this follow-up ๐ Reconcile gitlab lint jobs and commit-code-check.sh Needs work . Back to needs review.
- Status changed to Needs work
over 1 year ago 8:12pm 12 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Some nits around consistency in the templates, but I think this is almost ready for RTBC and continuing improvements in followups.
- last update
over 1 year ago 30,150 pass - last update
over 1 year ago 30,150 pass - Status changed to Needs review
over 1 year ago 8:05am 13 September 2023 - Status changed to RTBC
over 1 year ago 9:26am 13 September 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Thanks! This looks ready to go, I've gone over all changes a couple of times and can find nothing left to nitpick over - see you all in the followups.
- ๐ฌ๐งUnited Kingdom catch
Moving this to 10.1.x for backport. We need to tweak the central gitlab templates so that branch tests actually run after a branch commit, so will backport to 10.1.x as soon as this is done.
- Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - Open on Drupal.org โEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - Status changed to Fixed
over 1 year ago 1:19pm 13 September 2023 - ๐ฌ๐งUnited Kingdom catch
11.x pipeline: https://git.drupalcode.org/project/drupal/-/pipelines/19594
10.1.x pipeline: https://git.drupalcode.org/project/drupal/-/pipelines/19603
A bit more work to do before we can switch of DrupalCI but this is a massive improvement in so many ways. Marking fixed!
Automatically closed - issue fixed for 2 weeks with no activity.