Cloning simplenws issue copies sending status

Created on 7 September 2023, over 1 year ago

Problem/Motivation

This module is a great module and I would like to use it with simplenews module, to duplicate simplenews issues.
Unfortunately when we use quick_node_clone on a simplenews issue content, all the data from the original node for the field simplenews_isssue is set on the new node;
So, if the original node has already been sent before the duplication, the new node is considered as sent too and can't be send.

Proposed resolution

I propose to remove the data for the field simplenews_issue when duplicated data are set on the new node .
I add patch in this issue.

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡«πŸ‡·France lucuhb

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @lucuhb
  • πŸ‡©πŸ‡ͺGermany Kniekel

    Thank you very much! This module together with this patch makes my life so much easier.

  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9

    Is this feature needed? Would the "Exclusion list" options in Quick Node Clone's settings work, to exclude cloning the simplenews_issue field?

  • πŸ‡«πŸ‡·France lucuhb

    The exclusion list options in quick node Clone's settings don't currently concern simplenew_issue field.
    Without the patch, quick node clone module can't really be used with simplenews issues.
    If this patch could be added in the module, it would be great !

    Add a checkbox concerning simplenew_issue field in the module settings doesn't seem useful because I don't think anyone would want to create a simplenews that would be considered already sent.

  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9

    The exclusion list options in quick node Clone's settings don't currently concern simplenew_issue field.

    I am sorry. I don't understand. Does the exclusion list not work for simplenew_issue?

  • πŸ‡«πŸ‡·France lucuhb

    You are right, the field is in the exclusion list (the wording misled me).
    So no need for this patch, very sorry for the inconvenience.

  • πŸ‡ΊπŸ‡ΈUnited States bluegeek9
  • πŸ‡©πŸ‡°Denmark ressa Copenhagen

    I can confirm that the solution proposed here fixes the problem:

    1. Under "Exclusion list" > "Entity Types", check "Newsletter Issue"
    2. Under "Fields" > "simplenews_issue", check "Newsletter"

    If you now clone an already sent Simplenews newsletter, you need to select a Newsletter, the "Sent"-value is not carried over, and the cloned newsletter can be send (the "Send now" button is present).

  • πŸ‡©πŸ‡°Denmark ressa Copenhagen

    This is probably something all Simplenews and Quick Node Clone users will experience ... Is a mention on the project page or in the README worth considering?

Production build 0.71.5 2024