Follow Drupal CSS/BEM standards and modernize CSS at all

The one site using 4.x is in our hands, so lets go.

Anybody → closed merge request !6

First things fixed. I'll use this issue to modernize the CSS too.

All done, please review! Its tested, everything works well so far.

Changed the look a bit, the new styles do not override the page/Drupal theme styles like it was before.
Furthermore added Twig blocks to the template.

So everything should be nice and clean now.

https://git.drupalcode.org/issue/ouibounce_exit_modal-3385518/-/commits/...

Anybody → closed merge request !7

Please not that this is a breaking change from 3.x - which is okay for a major release, but should be well documented and users should be informed.

For the reasons given above (no 4.x installs yet beside our own), this is still fine, I think.

but should be well documented and users should be informed.

Okay, how do we do that? By adding a hint to the module description?

Well done, I left some comments @thomas.frobieter

I'll adjust the code accordingly.

nvm

We should fix 📌 Use data-attributes to define close triggers Active afterwards before creating a new RC release.

All threats resolved. RTBC! Thank you for the modernization!

Merged.

Automatically closed - issue fixed for 2 weeks with no activity.