- Issue created by @thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
Is this something that should instead be solved in the library upstream?
I don't know, the close triggers where defined in the module js before ... its 4 lines of code (while the JS is reduced 1/3 by this change).
So creating a issue in the library, waiting for implementation ..... meh.Done! Already tested, please review (:
https://git.drupalcode.org/issue/ouibounce_exit_modal-3385648/-/commit/7...
- Merge request !9Issue #3385648: Use data-attributes to define close triggers → (Merged) created by Anybody
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Assigned to Grevil
- Status changed to Needs review
over 1 year ago 3:53pm 6 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Please do not forget to open a MR from the issue fork and set the status to "Needs Review".
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - 🇩🇪Germany Anybody Porta Westfalica
Alternative: ✨ Replace ouibounce by vanilla JS + Drupal dialog modal Active
But we could still finish this.
- First commit to issue fork.
- 🇩🇪Germany Grevil
All done and tested! Please review!
I hope the ESLint formatting is not too unrelated.
- 🇩🇪Germany Anybody Porta Westfalica
VERY nice improvements @thomas.frobieter and @grevil! I left one final comment.
If this was well tested, I think it's ready for RTBC, I just did a code-review.
- 🇩🇪Germany Grevil
All done! Accidentally added the .gitlab-ci, composer.json and generic test here.
Automatically closed - issue fixed for 2 weeks with no activity.