Make it easier to add a child taxonomy term

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

@DSushmita this is not a new project application, it is only a new feature request in Drupal core issues queue. You can check all project applications in this issue queue: https://www.drupal.org/project/issues/projectapplications → , where you can help review these. Please stop posting such comments in the Drupal core issues queue. Thanks!

Restoring the status back to Active, as there is no patch yet.

Taxonomy terms can have multiple parents. I am modifying the Term form so that it accepts query strings like

• parent=4
• parent[0]=1&parent[1]=4

even though, for this issue, I will only create links like the first one. We can handle the two cases uniformly with (array) $this->getRequest()->query->all()['parent'].

For now, I set the parent term(s) whenever there is a parent query parameter, whether or not the term is new. That is, both the Add form and the Edit form pay attention to the query parameter. I can change this if anyone has a reason to allow it only on the Add form.

I think the current MR works, but I have not added tests yet.

I added some test coverage, so this issue is ready for review.

I am updating the issue summary. I am also planning to make a little change to the tests.

I have added a draft change record, and I am adding a release-notes snippet to the issue description.

Tested on an Umami install I had
In the Recipe category taxonomy added a child link to a random taxonomy
Verified it saved as the parent.
Added a child link to that taxonomy term I just created
Verified it saved 2 levels deep.

Added a child link to a level 1 term
But instead of clicking save and go to list I just clicked save.
Verified the next link still remembers the parent, so I created 3 child links, great feature!

LGTM!

This seems like a great improvement especially when maintaining large and complex sets of taxonomy terms.

Committed f1a5297 and pushed to 11.x. Thanks!

lauriii → closed merge request !4800

Automatically closed - issue fixed for 2 weeks with no activity.