Return type of getTranslationFromContext can be more specific

Seems to make sense but can't find any example in core where this has been used before so will see what the committers think.

Commented the MR

Would agree T is not clear at all without looking at this issue. But would also agree using "Template" I would assume there's a file for it. Of the two think T avoids the issue more.

The Drupal Coding standards do not include the use of this tag. See Tag reference →

And if it is used it will not display correctly on api.drupal.org. One such case has already slipped in, https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util....

If we want to use that feature we should have a Coding Standards issue to discuss it and, if approved, have api.drupal.org updated.

For now, I have tagged it and pinged the other Coding standards project maintainers.

I discussed this with catch, who pointed out that @template is already in core, There is an existing example, DeprecationHelper::backwardsCompatibleCall. We agreed to create an issue to add @template to api.drupal.org. I did that, 📌 Support @template Active .

We both agree that the name of the template should be meaningful, which 'T' is not. Also, the title suggests that this is adding information to the return type but the return type is not being changed. Therefor, also tagging for a title update.

I also don't want this issue to be a precedent for other issues to start adding @template. If we are going to do that for core, some planning will need to be done first..

Calling the template T when there is only one for a method is a pretty standard way of doing it.

The PHPStan docs use T: https://phpstan.org/blog/generics-in-php-using-phpdocs#type-variables

This has been inherited from Java generics which use T by default, or T1/T2/T3, or other single letters in some special cases: https://docs.oracle.com/javase/tutorial/java/generics/types.html

In order to not break the existing @param and @return docs I wonder if we should use the PHPStan-specific syntax here for now?

https://phpstan.org/blog/generics-in-php-using-phpdocs#ide-compatibility