Toolbar anti-flicker js shows for anonymous users

tried to address the ccf failure in #2.
please review.

Can I ask why

+    '#access' => \Drupal::currentUser()->hasPermission('access toolbar'),
+    '#cache' => [
+      'keys' => ['toolbar'],
+      'contexts' => ['user.permissions'],
+    ],

was removed in #3 when it was added in #2?

As a major issue wonder if this will need a test.

Didn't _utsavsharma exlpain it? He addressed the Custom Command Failure: https://www.drupal.org/pift-ci-job/2732769 →
the array keys were repeated.

Yes #3 is fine, removing cruft from #2.

If we move this to a file in the header (which I think we should, but not necessarily in this issue), then we'll have built-in test coverage of this from the NoJavascriptAnonymousTest, but that was rejected on the other issue.

This issue included the addition of inline JavaScript to so it could load before anything on the page was rendered.i got fixed by adding this to the .theme file instead of creating a new page inc

function THEME_page_attachments_alter(&$variables) {
  if(\Drupal::currentUser()->isAnonymous()) {
    $variables['#attached']['html_head'] = array_filter($variables['#attached']['html_head'], function($item) {
      return $item[1] !== 'anti_flicker_js';
    });
  }

I'm trying to use the provided patch but using it with cweagans/composer-patches, composer hangs and never finishes the process. This doesn't happen with any of the other patches i've got in the same build. Is this patch working for any of you?

Meanwhile I'm using the workaround provided in #7, thank you!

This issue can have effects beyond just the unnecessary javascript. If you are a user who has toolbar access after logging out your toolbar settings are still present in the sessionStorage javascript object and toolbar classes will be added to the body tag, making space for a toolbar that will never show up.

I am also facing the same issue in Drupal 10.1.1, the patch #3 works for Anonymous users and still the issue present for Admin users.

Please refer this patch - https://www.drupal.org/project/drupal/issues/3355381#comment-15196226 🐛 Investigate better ways to add anti-flicker JS Fixed

It works fine and fix the issue.

Another confirmation from issue page - https://www.drupal.org/project/drupal/issues/2998451#comment-15115386 🐛 Toolbar tray rendering can result "flickering" resizing of content area to accommodate open trays Fixed

@manikandank03 the patch doesn't solve the problem for me.
Patch #3 is working or workaround from #7 is also working. No javascript code for anonymous user.

🐛 Investigate better ways to add anti-flicker JS Fixed is RTBC so marking this postponed - if that gets committed, we can just close this one.

🐛 Investigate better ways to add anti-flicker JS Fixed landed.