- Issue created by @markie
- 🇺🇸United States ultimike Florida, USA
I've been working to go through all the open 2.x bug reports to see where we stand with each. Here's a summary:
- 🐛 Support unicode characters at trim_suffix (ellipsis) Fixed - this is a minor issue (IMHO) that is probably an easy fix and test, but does require some research to see how/if other core/contrib module handle things like this (if at all) and to make sure there are no security implications.
- 🐛 Maximum function nesting level reached for elements with many children on environments with XDebug RTBC - patch exists, needs to be converted into a MR and confirm that tests pass. Seems like a good issue for a novice-ish contributor.
- 🐛 noscript content appearing when HTML is being stripped Postponed: needs info - Unclear what a test would look like, so postponed until someone can provide more info.
- 🐛 Regression: More Labels No Longer Translated Fixed - interesting issue with current MR that works, but is not the 100% ideal solution. The ideal solution currently involves a core patch, so it seems we are moving towards a consensus where we merge in what we have, but then update things once the core patch lands.
- 🐛 Unclear trimming behavior (whole words or not?) - missing setting Active - personally, I think this should be marked as "Closed (won't fix)", but would be good to have additional input.
- 🐛 Settings from fields not validating correctly. Active - not a major issue and has a contributor working on it, so I'd love to see @sanket.addweb bring this one home.
- 🐛 Error cropping Japanese Needs work - this is a major issue involving character sets and probably RTL languages. This will likely involve a big refactoring of the code base and I don't think we are in a position to tackle this at the moment. We especially need a contributor with experience with non-Western character sets.
- 🐛 Wrong More link aria-label token [node:title] on non-nodes Needs work - probably an easy change, but need some input from someone with accessibility experience.
So, I think we should aim to get the following merged before releasing 2.1.1:
- 🐛 Support unicode characters at trim_suffix (ellipsis) Fixed
- 🐛 Maximum function nesting level reached for elements with many children on environments with XDebug RTBC
- 🐛 Regression: More Labels No Longer Translated Fixed
- 🐛 Wrong More link aria-label token [node:title] on non-nodes Needs work
I'll probably start working on the first two in the near future unless someone else picks them up and starts moving forward.
-mike
- 🇺🇸United States ultimike Florida, USA
Both 🐛 Support unicode characters at trim_suffix (ellipsis) Fixed and 🐛 Maximum function nesting level reached for elements with many children on environments with XDebug RTBC are now ready for review.
-mike
- 🇮🇪Ireland lostcarpark
I know 🐛 Support unicode characters at trim_suffix (ellipsis) Fixed is a minor issue, but it still strikes me as a new feature. Is that appropriate for a patch release, or should it be held for 3.2.0?
I think the other three can all be considered bugfixes.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Given how much time has passed since the last commit, I suggest releasing the current 2.1.x as 2.1.1 and hold the remaining issues for 2.1.2.
This is a fast and easy tool for making release notes:
- @markie opened merge request.
- Status changed to Needs review
9 months ago 3:22pm 25 February 2024 - Status changed to Fixed
9 months ago 3:51pm 25 February 2024 - 🇮🇪Ireland lostcarpark
Great to see a new release. I do think some of these changes are new features rather than bug fixes, so I would have preferred a minor release to a patch release.
But happy to see it regardless.
Automatically closed - issue fixed for 2 weeks with no activity.