Maximum function nesting level reached for elements with many children on environments with XDebug

Let's convert this to an issue fork against 2.1.x and see how it goes. Seems like a reasonable change (and it has an associated test!)

-mike

I converted the patch into an MR (tests passing) - I also tweaked the test data a little.

Needs a review or two.

-mike

MR makes sense but are there testing instructions for it? Does the pipeline check xdebug? What limits the test to just 3 instances of the test string?

Not enough to say "needs work" but am curious..

My understanding of this issue is if there are bucketloads of HTML elements in the field that Smart Trim is operating on, when using xdebug, the xdebug.max_nesting_level limit can be hit.

For manual testing, you'd need data to be Smart Trimmed that contains a bunch of HTML - so much that the xdebug.max_nesting_level it hit (as well as xdebug enabled, obviously).

The Gitlab pipeline does not run with xdebug enabled as far as I know.

-mike

Hello.

MR was applied as expected. +1 RTBC.

Merging this in. Thanks

Automatically closed - issue fixed for 2 weeks with no activity.