Settings from fields not validating correctly.

All valid questions - especially the "trim units" field not being an integer 😱

A couple of thoughts:

1. Let's tackle this one when/if 📌 "More link" formatter configuration UI improvements Fixed is committed.
2. We should take a look at other core/contrib modules to see how/if they handle validation in formatter config.

-mike

I resolved the issue by changing the field type from 'textfield' to 'number' and making the 'More text URL' field required when the 'Display More link?' checkbox is checked.

@sanket.addweb, looks an interesting solution.

Changing the field to a number makes sense.

Making the "More text URL" required when "Display more link" is checked, but from a quick look, this is only implemented on the form generation. If the user checks "Display more link", the URL field will be shown, but will not be required until the form is submitted. The ideal would be to add a validate function to check if the field is populated, but it doesn't appear to be possible to add validation to a field formatter.

I have fixed this issues and some change.

One minor point, the checkboxStatus or testcheckboxStatus function in the above patches is only called from within the class, so I think it should be a protected member rather than a public one.

@lostcarpark, I have made the necessary changes by replacing the public function with a protected function. Additionally, I conducted research on the "validateSettingsForm()" method and applied the validate handler in the formatter's setting form. However, the current implementation is not functioning as expected. I will continue investigating to identify and resolve the issue.

@all, Moving to need review status

Applied patch #7 to smart_trim:^2.1 and manually tested with drupal 10.2.6. All looks good.
Since field settings are updated by ajax request. So error message are stored in session.
And when you finally save the changes then error message appear with successfully settings saved message.

Btw this is expected behavior. So marking this for RTBC

@sanket.addweb - thanks for your efforts on this. Moving back to "Needs work" because we need to add at least one test for this. I would like to see a test that attempts to set the "Trim units" field to a non-integer and maybe also a test that covers the #required bit.

-mike