bottom margin in multi value field table display

@stefan.korn I have applied the patch #2 and applied successfully. The separator alignment working fine in GIN. We are good to RTBC +1

Hi @stefan.korn,

I have applied the patch #2 and applied successfully.

Here is the steps:-

1. Installed smart date module →
2. created field into Article content type

After added field in Article content type i get this issue but this issue is not fixed after applied patch #2,

please have a look Screen short

let me know if there is something i forgot

Thanks!

@djsagar: This is a single value field? Probably there is some other css selector combination causing the issue with single value field. Need to have a look at this.

For a single value field this is not a Gin issue, as Claro is looking the same:

And the separator label is not aligned really out of place, just more to the bottom as with multi value field. So one can maybe accept this discrepancy. But surely consistent look between single value and multi value would be preferable. But as this is not direclty Gin related, it probably should get fixed within the smart date module. Feel free to open an issue there or I will do if I find the time.

For Gin I suppose this patch is complete and fixes the issue for multi value fields as described.

@stefan.korn: Thank you for sharing your feedback.
Will check this.

I believe that part of the issue here is that Gin adds margin only to the bottom of the fields in this context. I created an MR that takes the same approach as the patch by @stefan.korn but also balances the top and bottom margins. In my testing this allowed the positioning of the separator to look the same as in Claro.

@mandclu I have checked the "MR !294" working fine.

After installing the smart date module, I created a field on the Basic content type page and the date range alignment works fine.
Please check the below image for the same.

Moving to + RTBC.

Moving this back to needs work as there are fixed values used and not Gin's CSS variables. E.g. --gin-spacing-xs

I have updated the code with the gin variable for the multiple date range fields as per the suggestion.
Please check the patch. I have attached the image after adding the patch.

Update the code in the _table.scss file:

tr .form-items-inline > .form-item {
    margin-top: var(--gin-spacing-l);
    margin-bottom: var(--gin-spacing-l);
  }

After updating to the latest release of Gin, the alignment of Smart Date items looked even more uneven. I wasn't sure how much these issues would apply to multi valued fields generally, versus being specific to Smart Date (I suspect more the latter). I opened this issue 🐛 Smart Date fields look wonky with latest Gin release Active against Smart Date to fix the alignment issues, which turned out to be a pretty simple fix.

Anyone on this issue who is really looking to improve the display of Smart Date fields, please comment on that issue, and I should be able to spin a new release quickly.

@mandclu thanks for fixing this in smart date directly 👏

Can we close this issue as this has been fixed in smart date itself? Or is there still anything open?

Based on my own experience I would say this is fixed, but it would be ideal if someone else in this thread could chime in to confirm.

Closing