- Issue created by @fgm
- First commit to issue fork.
- Merge request !4Issue #3378704: Module is missing a config schema for validation β (Merged) created by elber
- Status changed to Needs review
over 1 year ago 2:54pm 2 August 2023 - π§π·Brazil elber Brazil
Hi @fgm do you also want a settingsForm file to define the module settings?
- π«π·France fgm Paris, France
Hi @elber : no, the module has no settings, the settings are only on the formatters, so there is no specific config file or settings form needed, AFAICS.
- π«π·France fgm Paris, France
Otherwise, that schema you suggested in the MR is a start, but we need to go further, especially converting the text settings to a "sequence of integer" instead. And add an update hook for the format change.
- π«π·France fgm Paris, France
Actually we do not need an update hook: the code supports the legacy format and saves to the new format when updating the config.
- π«π·France fgm Paris, France
And in patch format for those who prefer to review patches.
- π«π·France fgm Paris, France
@wimleers suggestions on slack
For examples:
https://www.drupal.org/project/drupal/issues/3377030 π Add validation constraint to `type: label`: disallow multiple lines Fixed
https://www.drupal.org/node/2920678 β
So in this case, I think you want \Drupal\Core\Validation\Plugin\Validation\Constraint\RangeConstraint :slightly_smiling_face: - Assigned to pguillard
- Issue was unassigned.
- Status changed to Needs work
12 months ago 5:03pm 4 January 2024 - π·πΈSerbia bojanz
Sorry, I merged π Fix snake_case/camelCase Needs review without seeing that this issue is in conflict, we'll need to rebase it.
- π·πΈSerbia bojanz
Crediting AstonVictor for the duplicate at π Add validation for delta Needs review .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Posted an initial review π
- Status changed to Fixed
8 months ago 2:59pm 12 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.