Remove hardcoded "X minutes" translatable strings

+1 to doing this, we already use the @count version in some places:

core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/TimestampFormatter.php:      300 => $this->t('@count minutes', ['@count' => 5]),
core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/TimestampFormatter.php:      600 => $this->t('@count minutes', ['@count' => 10]),

but not others

core/modules/datetime_range/src/Plugin/Field/FieldWidget/DateRangeDatelistWidget.php:          5 => $this->t('5 minutes'),
core/modules/datetime_range/src/Plugin/Field/FieldWidget/DateRangeDatelistWidget.php:          10 => $this->t('10 minutes'),
core/modules/datetime_range/src/Plugin/Field/FieldWidget/DateRangeDatelistWidget.php:          15 => $this->t('15 minutes'),
core/modules/datetime_range/src/Plugin/Field/FieldWidget/DateRangeDatelistWidget.php:          30 => $this->t('30 minutes'),

core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDatelistWidget.php:          5 => $this->t('5 minutes'),
core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDatelistWidget.php:          10 => $this->t('10 minutes'),
core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDatelistWidget.php:          15 => $this->t('15 minutes'),
core/modules/datetime/src/Plugin/Field/FieldWidget/DateTimeDatelistWidget.php:          30 => $this->t('30 minutes'),

@apaderno: Thx for the typo fix in the issue summary.

@longwave: Yes, I checked the source code before creating the issue and found what you posted. Thx for the +1 ;-)

I created an issue fork and a simple commit that I pushed to the branch of the fork. The instructions → were not 100% clear about whether I should do a MR, but I did :-) First patch for the new Gitlab setup.

You can do MRs or patches, whatever is easiest. Eventually we will move fully to GitLab and only use MRs, but not yet.

There is a missing ) here:

+          10 => $this->t('@count minutes', ['@count' => 10],

I noticed the typo myself ;-)

Applied the MR and did a regex search with \('\d* minutes'\) and all 8 instances have been replaced.

Committed e5ebeb3 and pushed to 11.x. Thanks!

lauriii → closed merge request !4527

Automatically closed - issue fixed for 2 weeks with no activity.