[D10] - Plan WxT 5.0.0 release

Some internal classes related warning left. So leaving it in Needs Work status.

@shivam looks like your MR was made against the 4.5.x branch, think it should be against 5.0.x.

shivam_tiwari → closed merge request !15

Thanks @shivam_tiwari, MR 16 looks good.

I think the only thing left is to test the upgrade process from 4.5.x -> 5.0.x as I'm sure there has to be something install hooks we have to do.

I think @smulvih was going to take a look at this and comment back. :)

@sylus, I've already tested the upgrade process a few times now from 4.5.x to 5.0.x , all the issues I encountered have been resolved and the upgrade process should go well in most cases now.

Once the footnotes module is tagged/published and brought in, this should make things easier for people so they don't have to deal with adding extra composer.json entries over and above the normal. Even still, I think @smuvih2 was able to use perhaps his new 3.1.x branch? or maybe not, I think there's a tagged release we're hung on because the maintainer hasn't yet granted @smulvih2 full maintainer privs yet.

@sylus I think the only update hook we need is wxt_core_update_8500(), which uninstalls the wxt_ext_config module (to be removed in subsequent release). - https://github.com/drupalwxt/wxt/blob/4ac1aebc5d5fd46d66631da3380063e79254a852/modules/custom/wxt_core/wxt_core.install#L631

I did a fresh install of WxT 4.5.3 and setup some default content. Then I upgraded to the latest 5.0.x branch. I was getting a WSOD on all non-admin pages:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "node_type" plugin does not exist. Valid plugin IDs for Drupal\Core\Condition\ConditionManager are: group_type, language, current_theme, request_path, user_role, webform, wxt_is_archived, panels_title, entity_bundle:block_content, entity_bundle:comment, entity_bundle:entity_subqueue, entity_bundle:group_content, entity_bundle:group, entity_bundle:media, entity_bundle:menu_link_content, entity_bundle:node, entity_bundle:shortcut, entity_bundle:taxonomy_term, entity_bundle:webform_submission, entity_bundle:paragraph in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

I traced this back to the sidebar block config. In D9 the plugin id is node_type, but this is removed in D10 and should be replaced with entity_bundle:node.

Here is where this config is originally set in D9 WxT - https://github.com/drupalwxt/wxt_bootstrap/blob/4764194ee1acd9667b6180d8c53fa3fd3f194d38/config/optional/block.block.sidebar.yml#L36

Here is the change in D10 WxT - https://github.com/drupalwxt/wxt_bootstrap/blob/e7233eb4b307a0f23c26a9504bcbe3800729883f/config/optional/block.block.sidebar.yml#L36

The patch attached update the hook_update_8500() to loop through all block configs and update this value programmatically. Once this was ran, I was able to see all of my content originally created in D9. I was also able to use CKE4 for existing content. @joseph are you able to support codemirror in CKE4 and CKE5 in parallel? Would be nice to have codemirror set for CKE4 when the upgrade is done, since this is the only CKE4 regression I noticed.

I think we should leave any changes to the text formats up to each project, since some will elect to stay with CKE4 for a period of time (e.x. using a lot of CKE plugins from contrib), and some will want to upgrade to CKE5. New projects will be able to start fresh with CKE5.

I took your updated hook @smulvih2 thanks!

So the only thing remaining is getting codemirror to work in CKEditor 4.

I know we mentioned just going straight to CKEditor5 but maybe it makes sense to support both 4/5 to limit problems.

I know @joseph had an issue for this so might re-open and just accept it for now and set a timebox where we expect people to update?

Ok with codemirror in, is the only thing left some documentation?

Do we want to do an RC release right now?

Yes we should have some documentation to go with this release. I can look at doing this over the next week.

Let's get an RC out now! It's perfect timing, I will be looking at updating the CRA build to D10 WxT next week.

ya 5.0.0-rc1 sounds good

Documentation for the upgrade, I started something here:
#3378351: [D10] - WxT 4.5.3 to 5.0.0 - Upgrade steps and helpful instructions [DRAFT] →

@smulvih2 @sylus, how soon before we can pop the bubbly on a 5.0.0-rc1?

@joseph think it's time to crack that bottle - https://www.drupal.org/project/wxt/releases/5.0.0-rc1 →

w00t ok share some virtual champagne.

       ___
    .-     \
   /   _    \
  |  /   \   \
   \|     \   \
    \      \   \
     \      \   \
      \     _\   \
       \  /       \
        \|         |
         \  ~      |
          \.__ ~   \
              \     \
               \     \
                \     \
                 \ ._=_\
                  \/    >
                   ` \\\
                  .  \\\\   .
                 .    |||| .   .
                _________________
               <_________________>
                \ _________o___ /
                  \    o  .   /
                    \   .   /
                      \   /
                       | |
                       | |
                       | |
                       | |
                    ___| |___
                 _--         --_
                   -----------

for RC2 maybe?

Thanks for 5.0.0-rc2, I haven't had a chance yet to try it.

Testing 5.0.0-rc2
here's a patch to improve it
#3382999: [D10] - Build update for wxt, upgrade ckeditor4_codemirror to 1.0.4 →

Marking as fixed since we now have a 5.0.0 release available.

Automatically closed - issue fixed for 2 weeks with no activity.