- Issue created by @trigve hagen
- Status changed to Needs review
over 1 year ago 11:21am 27 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
Reviewer's task is describing what needs to be changed, not providing patches to fix what reported in a review. - If you have not done it yet, you should run
- Status changed to Needs work
over 1 year ago 3:43am 1 August 2023 - 🇮🇳India vinaymahale
Please set the default branch to 3.0.x
Also fix the below PHPCS issues:
FILE: /testsuite/testsuite.services.yml ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 22 | ERROR | [x] Expected 1 newline at end of file; 3 found ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: /testsuite/testsuite.module ------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------ 5 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 8 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 9 | WARNING | [ ] There must be no blank line following an inline comment 9 | ERROR | [x] Inline comments must start with a capital letter 9 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 22 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 29 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ) ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /testsuite/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 443 characters 20 | WARNING | Line exceeds 80 characters; contains 527 characters 25 | WARNING | Line exceeds 80 characters; contains 585 characters 30 | WARNING | Line exceeds 80 characters; contains 439 characters 32 | WARNING | Line exceeds 80 characters; contains 311 characters ---------------------------------------------------------------------- FILE: /testsuite/tests_module/custom_tests/custom_tests.info.yml.txt ----------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 90 characters ----------------------------------------------------------------------------------------------------------- FILE: /testsuite/tests_module/custom_tests/src/CustomTSTests/CheckFor404Errors.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 62 ERRORS AND 6 WARNINGS AFFECTING 48 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Missing class doc comment 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [ ] Missing short description in doc comment 13 | ERROR | [x] Do not append variable name "$_moduleName" to the type declaration in a member variable comment 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | WARNING | [ ] Property name "$_moduleName" should not be prefixed with an underscore to indicate visibility 15 | ERROR | [ ] Class property $_moduleName should use lowerCamel naming without underscores 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [x] Do not append variable name "$_menuName" to the type declaration in a member variable comment 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | WARNING | [ ] Property name "$_menuName" should not be prefixed with an underscore to indicate visibility 20 | ERROR | [ ] Class property $_menuName should use lowerCamel naming without underscores 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [x] Do not append variable name "$_name" to the type declaration in a member variable comment 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | WARNING | [ ] Property name "$_name" should not be prefixed with an underscore to indicate visibility 25 | ERROR | [ ] Class property $_name should use lowerCamel naming without underscores 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [x] Do not append variable name "$_description" to the type declaration in a member variable comment 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | WARNING | [ ] Property name "$_description" should not be prefixed with an underscore to indicate visibility 30 | ERROR | [ ] Class property $_description should use lowerCamel naming without underscores 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Doc comment short description must end with a full stop 35 | ERROR | [ ] Description for the @return value must be on the next line 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Doc comment short description must end with a full stop 44 | ERROR | [ ] Description for the @return value must be on the next line 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Doc comment short description must end with a full stop 53 | ERROR | [ ] Description for the @return value must be on the next line 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 60 | ERROR | [x] Doc comment short description must end with a full stop 62 | ERROR | [ ] Description for the @return value must be on the next line 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Opening brace should be on the same line as the declaration 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8 74 | ERROR | [x] Short array syntax must be used to define arrays 79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 79 | ERROR | [x] Expected 1 space after IF keyword; 0 found 79 | ERROR | [x] Inline control structures are not allowed 79 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 80 | ERROR | [x] Inline control structures are not allowed 80 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 80 | ERROR | [x] Short array syntax must be used to define arrays 81 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Expected 1 newline at end of file; 0 found 84 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 50 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/tests_module/custom_tests/src/CustomTSTests/MicrosoftConnectionTest.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 95 ERRORS AND 8 WARNINGS AFFECTING 81 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | [x] Missing class doc comment 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [ ] Missing short description in doc comment 17 | ERROR | [x] Do not append variable name "$translateUrl" to the type declaration in a member variable comment 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [ ] Missing short description in doc comment 22 | ERROR | [x] Do not append variable name "$tokenUrl" to the type declaration in a member variable comment 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [x] Do not append variable name "$_moduleName" to the type declaration in a member variable comment 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | WARNING | [ ] Property name "$_moduleName" should not be prefixed with an underscore to indicate visibility 29 | ERROR | [ ] Class property $_moduleName should use lowerCamel naming without underscores 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [ ] Missing short description in doc comment 32 | ERROR | [x] Do not append variable name "$_menuName" to the type declaration in a member variable comment 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | WARNING | [ ] Property name "$_menuName" should not be prefixed with an underscore to indicate visibility 34 | ERROR | [ ] Class property $_menuName should use lowerCamel naming without underscores 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [ ] Missing short description in doc comment 37 | ERROR | [x] Do not append variable name "$_name" to the type declaration in a member variable comment 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | WARNING | [ ] Property name "$_name" should not be prefixed with an underscore to indicate visibility 39 | ERROR | [ ] Class property $_name should use lowerCamel naming without underscores 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [ ] Missing short description in doc comment 42 | ERROR | [x] Do not append variable name "$_description" to the type declaration in a member variable comment 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | WARNING | [ ] Property name "$_description" should not be prefixed with an underscore to indicate visibility 44 | ERROR | [ ] Class property $_description should use lowerCamel naming without underscores 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Doc comment short description must end with a full stop 49 | ERROR | [ ] Description for the @return value must be on the next line 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Doc comment short description must end with a full stop 58 | ERROR | [ ] Description for the @return value must be on the next line 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Doc comment short description must end with a full stop 67 | ERROR | [ ] Description for the @return value must be on the next line 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Doc comment short description must end with a full stop 76 | ERROR | [ ] Description for the @return value must be on the next line 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Opening brace should be on the same line as the declaration 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Use null coalesce operator instead of ternary operator. 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 89 | ERROR | [x] Use null coalesce operator instead of ternary operator. 90 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 92 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 93 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 93 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 94 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 96 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 96 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [ ] Parameter $api_region is not described in comment 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 118 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Concat operator must be surrounded by a single space 122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 124 | WARNING | [x] A comma should follow the last multiline array item. Found: $api_key 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 128 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 132 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 134 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 137 | ERROR | [x] Expected 1 newline at end of file; 0 found 137 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 81 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/css/testsuite_menu.css ------------------------------------------------------------------------------------------------ FOUND 101 ERRORS AFFECTING 97 LINES ------------------------------------------------------------------------------------------------ 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 167 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 190 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 101 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /testsuite/testsuite.links.menu.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 13 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /testsuite/src/ConfigService.php ------------------------------------------------------------------------------------------------- FOUND 38 ERRORS AND 4 WARNINGS AFFECTING 31 LINES ------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 19 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 20 | ERROR | [x] Short array syntax must be used to define arrays 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 21 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 21 | ERROR | [x] There should be no white space after an opening "{" 21 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters 21 | ERROR | [x] Comments may not appear after statements 22 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 23 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 24 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 25 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 26 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 27 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 28 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 29 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 30 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 30 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 32 | ERROR | [x] Case breaking statements must be followed by a single blank line 32 | ERROR | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16 33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 33 | ERROR | [x] Case breaking statements must be followed by a single blank line 33 | ERROR | [x] Closing brace must be on a line by itself 34 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 35 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 41 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Expected 1 blank line after function; 0 found 54 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /testsuite/src/LoadResourceService.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 512 ERRORS AND 12 WARNINGS AFFECTING 239 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [ ] Missing short description in doc comment 15 | ERROR | [x] Expected "arrayListofdirectoriesforthemenu" but found "array List of directories for the menu." for @var tag in member | | variable comment 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | WARNING | [ ] Property name "$_menuArray" should not be prefixed with an underscore to indicate visibility 17 | ERROR | [ ] Class property $_menuArray should use lowerCamel naming without underscores 17 | ERROR | [x] Short array syntax must be used to define arrays 18 | ERROR | [x] Short array syntax must be used to define arrays 19 | ERROR | [x] Short array syntax must be used to define arrays 20 | ERROR | [x] Short array syntax must be used to define arrays 20 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [x] Expected "arrayListofcustomtests" but found "array List of custom tests." for @var tag in member variable comment 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | WARNING | [ ] Property name "$_customTestsArray" should not be prefixed with an underscore to indicate visibility 26 | ERROR | [ ] Class property $_customTestsArray should use lowerCamel naming without underscores 26 | ERROR | [x] Short array syntax must be used to define arrays 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [ ] Missing short description in doc comment 29 | ERROR | [x] Expected "arrayListofphpunittests" but found "array List of phpunit tests." for @var tag in member variable comment 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | WARNING | [ ] Property name "$_formReportArray" should not be prefixed with an underscore to indicate visibility 31 | ERROR | [ ] Class property $_formReportArray should use lowerCamel naming without underscores 31 | ERROR | [x] Short array syntax must be used to define arrays 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [ ] Missing short description in doc comment 34 | ERROR | [x] Expected "arrayListoflinks" but found "array List of links." for @var tag in member variable comment 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | WARNING | [ ] Property name "$_listFilesArray" should not be prefixed with an underscore to indicate visibility 36 | ERROR | [ ] Class property $_listFilesArray should use lowerCamel naming without underscores 36 | ERROR | [x] Short array syntax must be used to define arrays 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [ ] Missing short description in doc comment 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | WARNING | [ ] Property name "$_connection" should not be prefixed with an underscore to indicate visibility 41 | ERROR | [ ] Class property $_connection should use lowerCamel naming without underscores 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [ ] Missing short description in doc comment 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | WARNING | [ ] Property name "$_account" should not be prefixed with an underscore to indicate visibility 46 | ERROR | [ ] Class property $_account should use lowerCamel naming without underscores 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [ ] Missing short description in doc comment 49 | ERROR | [x] Expected "stringAbsolutepathtotheresource" but found "string Absolute path to the resource." for @var tag in member | | variable comment 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | WARNING | [ ] Property name "$_path" should not be prefixed with an underscore to indicate visibility 51 | ERROR | [ ] Class property $_path should use lowerCamel naming without underscores 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [ ] Missing short description in doc comment 54 | ERROR | [ ] Missing parameter comment 55 | ERROR | [ ] Missing parameter comment 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 81 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 84 | ERROR | [x] Case breaking statements must be followed by a single blank line 84 | ERROR | [x] Case breaking statement indented incorrectly; expected 14 spaces, found 16 85 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 86 | ERROR | [x] Expected 1 space after IF keyword; 0 found 87 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 88 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 89 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 90 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 91 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 91 | ERROR | [x] Expected newline after closing brace 92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 92 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 93 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 93 | ERROR | [x] Each PHP statement must be on a line by itself 93 | ERROR | [x] Case breaking statements must be followed by a single blank line 93 | ERROR | [x] Closing brace must be on a line by itself 93 | ERROR | [x] Each PHP statement must be on a line by itself 94 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 94 | ERROR | [x] Each PHP statement must be on a line by itself 94 | ERROR | [x] Case breaking statements must be followed by a single blank line 94 | ERROR | [x] Closing brace must be on a line by itself 94 | ERROR | [x] Each PHP statement must be on a line by itself 95 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 95 | ERROR | [x] Each PHP statement must be on a line by itself 95 | ERROR | [x] Closing brace must be on a line by itself 95 | ERROR | [x] Each PHP statement must be on a line by itself 96 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 97 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 98 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Expected 1 space after IF keyword; 0 found 122 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 122 | ERROR | [x] Expected 1 space after IF keyword; 0 found 123 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 123 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 124 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 124 | ERROR | [x] Case breaking statements must be followed by a single blank line 124 | ERROR | [x] Closing brace must be on a line by itself 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 125 | ERROR | [x] Case breaking statements must be followed by a single blank line 125 | ERROR | [x] Closing brace must be on a line by itself 125 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 126 | ERROR | [x] Closing brace must be on a line by itself 126 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Concat operator must be surrounded by a single space 127 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 128 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 128 | ERROR | [x] Expected newline after closing brace 129 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 129 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 130 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 130 | ERROR | [x] Case breaking statements must be followed by a single blank line 130 | ERROR | [x] Closing brace must be on a line by itself 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 131 | ERROR | [x] Case breaking statements must be followed by a single blank line 131 | ERROR | [x] Closing brace must be on a line by itself 131 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 132 | ERROR | [x] Closing brace must be on a line by itself 132 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Concat operator must be surrounded by a single space 133 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 134 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 135 | ERROR | [x] Expected newline after closing brace 136 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 136 | ERROR | [x] Expected 1 space after IF keyword; 0 found 137 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 137 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 138 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 138 | ERROR | [x] Case breaking statements must be followed by a single blank line 138 | ERROR | [x] Closing brace must be on a line by itself 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 139 | ERROR | [x] Case breaking statements must be followed by a single blank line 139 | ERROR | [x] Closing brace must be on a line by itself 139 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 140 | ERROR | [x] Closing brace must be on a line by itself 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 141 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 142 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 142 | ERROR | [x] Expected newline after closing brace 143 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 143 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 144 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 144 | ERROR | [x] Case breaking statements must be followed by a single blank line 144 | ERROR | [x] Closing brace must be on a line by itself 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 145 | ERROR | [x] Case breaking statements must be followed by a single blank line 145 | ERROR | [x] Closing brace must be on a line by itself 145 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 146 | ERROR | [x] Closing brace must be on a line by itself 146 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Concat operator must be surrounded by a single space 147 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 148 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 149 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 167 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 168 | ERROR | [x] Expected 1 space after IF keyword; 0 found 169 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 170 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 170 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Concat operator must be surrounded by a single space 171 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 171 | ERROR | [x] Expected newline after closing brace 172 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 172 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 172 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Concat operator must be surrounded by a single space 173 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 179 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters 191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 194 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 194 | ERROR | [x] Each PHP statement must be on a line by itself 194 | ERROR | [x] Case breaking statements must be followed by a single blank line 194 | ERROR | [x] Closing brace must be on a line by itself 194 | ERROR | [x] Each PHP statement must be on a line by itself 195 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 195 | ERROR | [x] Each PHP statement must be on a line by itself 195 | ERROR | [x] Case breaking statements must be followed by a single blank line 195 | ERROR | [x] Closing brace must be on a line by itself 195 | ERROR | [x] Each PHP statement must be on a line by itself 196 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 196 | ERROR | [x] Each PHP statement must be on a line by itself 196 | ERROR | [x] Closing brace must be on a line by itself 196 | ERROR | [x] Each PHP statement must be on a line by itself 197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 198 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 199 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 216 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 216 | ERROR | [x] Expected 1 space after IF keyword; 0 found 217 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 217 | ERROR | [x] Expected 1 space after IF keyword; 0 found 218 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 218 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 219 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 219 | ERROR | [x] Case breaking statements must be followed by a single blank line 219 | ERROR | [x] Closing brace must be on a line by itself 219 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Concat operator must be surrounded by a single space 220 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 220 | ERROR | [x] Case breaking statements must be followed by a single blank line 220 | ERROR | [x] Closing brace must be on a line by itself 220 | ERROR | [x] Concat operator must be surrounded by a single space 220 | ERROR | [x] Concat operator must be surrounded by a single space 220 | ERROR | [x] Concat operator must be surrounded by a single space 221 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 221 | ERROR | [x] Closing brace must be on a line by itself 221 | ERROR | [x] Concat operator must be surrounded by a single space 221 | ERROR | [x] Concat operator must be surrounded by a single space 221 | ERROR | [x] Concat operator must be surrounded by a single space 222 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 223 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 223 | ERROR | [x] Expected newline after closing brace 224 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 224 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 225 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 225 | ERROR | [x] Case breaking statements must be followed by a single blank line 225 | ERROR | [x] Closing brace must be on a line by itself 225 | ERROR | [x] Concat operator must be surrounded by a single space 225 | ERROR | [x] Concat operator must be surrounded by a single space 225 | ERROR | [x] Concat operator must be surrounded by a single space 225 | ERROR | [x] Concat operator must be surrounded by a single space 225 | ERROR | [x] Concat operator must be surrounded by a single space 226 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 226 | ERROR | [x] Case breaking statements must be followed by a single blank line 226 | ERROR | [x] Closing brace must be on a line by itself 226 | ERROR | [x] Concat operator must be surrounded by a single space 226 | ERROR | [x] Concat operator must be surrounded by a single space 226 | ERROR | [x] Concat operator must be surrounded by a single space 227 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 227 | ERROR | [x] Closing brace must be on a line by itself 227 | ERROR | [x] Concat operator must be surrounded by a single space 227 | ERROR | [x] Concat operator must be surrounded by a single space 227 | ERROR | [x] Concat operator must be surrounded by a single space 228 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 229 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 230 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 230 | ERROR | [x] Expected newline after closing brace 231 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 231 | ERROR | [x] Expected 1 space after IF keyword; 0 found 232 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 232 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 233 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 233 | ERROR | [x] Case breaking statements must be followed by a single blank line 233 | ERROR | [x] Closing brace must be on a line by itself 233 | ERROR | [x] Concat operator must be surrounded by a single space 233 | ERROR | [x] Concat operator must be surrounded by a single space 233 | ERROR | [x] Concat operator must be surrounded by a single space 233 | ERROR | [x] Concat operator must be surrounded by a single space 233 | ERROR | [x] Concat operator must be surrounded by a single space 234 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 234 | ERROR | [x] Case breaking statements must be followed by a single blank line 234 | ERROR | [x] Closing brace must be on a line by itself 234 | ERROR | [x] Concat operator must be surrounded by a single space 234 | ERROR | [x] Concat operator must be surrounded by a single space 234 | ERROR | [x] Concat operator must be surrounded by a single space 235 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 235 | ERROR | [x] Closing brace must be on a line by itself 235 | ERROR | [x] Concat operator must be surrounded by a single space 235 | ERROR | [x] Concat operator must be surrounded by a single space 235 | ERROR | [x] Concat operator must be surrounded by a single space 236 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 237 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 237 | ERROR | [x] Expected newline after closing brace 238 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 238 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 239 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 239 | ERROR | [x] Case breaking statements must be followed by a single blank line 239 | ERROR | [x] Closing brace must be on a line by itself 239 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Concat operator must be surrounded by a single space 240 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 240 | ERROR | [x] Case breaking statements must be followed by a single blank line 240 | ERROR | [x] Closing brace must be on a line by itself 240 | ERROR | [x] Concat operator must be surrounded by a single space 240 | ERROR | [x] Concat operator must be surrounded by a single space 240 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 241 | ERROR | [x] Closing brace must be on a line by itself 241 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Concat operator must be surrounded by a single space 242 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 243 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 244 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 245 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 247 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 255 | ERROR | [x] Additional blank lines found at end of doc comment 256 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 256 | ERROR | [ ] Private method name "LoadResourceService::_getCustomTests" is not in lowerCamel format 257 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 258 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 258 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 259 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 259 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 260 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 260 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 261 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 262 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 263 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 263 | ERROR | [x] Expected 1 space after IF keyword; 0 found 264 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 265 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 266 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 267 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 270 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 278 | ERROR | [x] Additional blank lines found at end of doc comment 279 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 279 | ERROR | [ ] Private method name "LoadResourceService::_getDirectories" is not in lowerCamel format 280 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 281 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 281 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 282 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 282 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 283 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 283 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 284 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 285 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 286 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 286 | ERROR | [x] Expected 1 space after IF keyword; 0 found 287 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 288 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 288 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 289 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 289 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 290 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 290 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 291 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 292 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 293 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 294 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 295 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 296 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 297 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 298 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 300 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 312 | ERROR | [x] Additional blank lines found at end of doc comment 313 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 313 | ERROR | [ ] Private method name "LoadResourceService::_getFilesInDirectories" is not in lowerCamel format 314 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 315 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 315 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 316 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 316 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 317 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 317 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 318 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 318 | ERROR | [x] Expected 1 space after IF keyword; 0 found 319 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 320 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 321 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 321 | ERROR | [x] Expected 1 space after IF keyword; 0 found 322 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 323 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 323 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 324 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 324 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 325 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 325 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 326 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 326 | ERROR | [x] Expected 1 space after IF keyword; 0 found 327 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 32 328 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 329 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 329 | ERROR | [x] Concat operator must be surrounded by a single space 330 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 331 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 331 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 332 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 40 333 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 334 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 32 335 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 336 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 337 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 338 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 339 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 340 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 341 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 343 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 355 | ERROR | [x] Additional blank lines found at end of doc comment 356 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 356 | ERROR | [ ] Private method name "LoadResourceService::_getFormReportArray" is not in lowerCamel format 357 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 358 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 358 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 359 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 359 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 360 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 360 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 361 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 362 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 363 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 363 | ERROR | [x] Expected 1 space after IF keyword; 0 found 364 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 365 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 365 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 366 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 366 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 367 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 367 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 368 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 368 | ERROR | [x] Expected 1 space after IF keyword; 0 found 369 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 370 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 32 370 | ERROR | [x] Expected 1 space after IF keyword; 0 found 371 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 372 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 32 372 | ERROR | [x] Expected newline after closing brace 373 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 36 373 | ERROR | [x] Expected 1 space after IF keyword; 0 found 373 | ERROR | [x] Inline control structures are not allowed 374 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 32 375 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 376 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 377 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 378 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 379 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 380 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 381 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 381 | ERROR | [x] Expected 1 blank line after function; 0 found 382 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 493 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/InitializerService.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 350 ERRORS AND 14 WARNINGS AFFECTING 196 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [ ] Missing short description in doc comment 14 | ERROR | [x] Expected "array\Drupal\testsuite\ConfigServiceconfigvariablesforthephpunitxmlfile" but found "array | | \Drupal\testsuite\ConfigService config variables for the phpunit.xml file." for @var tag in member variable comment 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | WARNING | [ ] Property name "$_databaseArray" should not be prefixed with an underscore to indicate visibility 16 | ERROR | [ ] Class property $_databaseArray should use lowerCamel naming without underscores 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [x] Expected "string\DrupalVERSION" but found "string \Drupal::VERSION" for @var tag in member variable comment 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | WARNING | [ ] Property name "$_version" should not be prefixed with an underscore to indicate visibility 21 | ERROR | [ ] Class property $_version should use lowerCamel naming without underscores 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [x] Do not append variable name "$_phpunitXmlDistPath" to the type declaration in a member variable comment 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | WARNING | [ ] Property name "$_phpunitXmlDistPath" should not be prefixed with an underscore to indicate visibility 26 | ERROR | [ ] Class property $_phpunitXmlDistPath should use lowerCamel naming without underscores 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [ ] Missing short description in doc comment 29 | ERROR | [x] Do not append variable name "$_phpunitXmlPath" to the type declaration in a member variable comment 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | WARNING | [ ] Property name "$_phpunitXmlPath" should not be prefixed with an underscore to indicate visibility 31 | ERROR | [ ] Class property $_phpunitXmlPath should use lowerCamel naming without underscores 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [ ] Missing short description in doc comment 34 | ERROR | [ ] Missing parameter comment 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [ ] Public method name "InitializerService::ifPHPUnitXmlExists" is not in lowerCamel format 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 52 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 52 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 60 | ERROR | [x] Additional blank lines found at end of doc comment 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 62 | ERROR | [x] Expected 1 space after IF keyword; 0 found 63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Additional blank lines found at end of doc comment 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 75 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 75 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | ERROR | [x] Expected newline after closing brace 76 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 77 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 77 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Additional blank lines found at end of doc comment 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 86 | ERROR | [x] Expected 1 space after IF keyword; 0 found 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 87 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 89 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters 95 | ERROR | [x] Additional blank lines found at end of doc comment 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 97 | ERROR | [x] Expected 1 space after IF keyword; 0 found 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 98 | ERROR | [x] Expected 1 space after IF keyword; 0 found 99 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 100 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 100 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 103 | ERROR | [x] Expected 1 space after IF keyword; 0 found 104 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 104 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Additional blank lines found at end of doc comment 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 112 | ERROR | [ ] Public method name "InitializerService::rebuildPHPUnitXml" is not in lowerCamel format 113 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 113 | ERROR | [x] Concat operator must be surrounded by a single space 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 115 | ERROR | [x] Concat operator must be surrounded by a single space 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Concat operator must be surrounded by a single space 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 117 | ERROR | [x] Concat operator must be surrounded by a single space 118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 118 | ERROR | [x] Concat operator must be surrounded by a single space 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 119 | ERROR | [x] Concat operator must be surrounded by a single space 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 120 | ERROR | [x] Concat operator must be surrounded by a single space 121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Concat operator must be surrounded by a single space 122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 122 | ERROR | [x] Concat operator must be surrounded by a single space 123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 123 | ERROR | [x] Concat operator must be surrounded by a single space 124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 124 | ERROR | [x] Concat operator must be surrounded by a single space 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 125 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 126 | ERROR | [x] Concat operator must be surrounded by a single space 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 127 | ERROR | [x] Concat operator must be surrounded by a single space 128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 128 | ERROR | [x] Concat operator must be surrounded by a single space 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 129 | ERROR | [x] Concat operator must be surrounded by a single space 130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 131 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Concat operator must be surrounded by a single space 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 133 | ERROR | [x] Concat operator must be surrounded by a single space 134 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 134 | ERROR | [x] Concat operator must be surrounded by a single space 135 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 135 | ERROR | [x] Concat operator must be surrounded by a single space 136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 136 | ERROR | [x] Concat operator must be surrounded by a single space 136 | ERROR | [x] Concat operator must be surrounded by a single space 136 | ERROR | [x] Concat operator must be surrounded by a single space 137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 137 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Concat operator must be surrounded by a single space 139 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 139 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 140 | ERROR | [x] Concat operator must be surrounded by a single space 141 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 141 | ERROR | [x] Concat operator must be surrounded by a single space 142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 142 | ERROR | [x] Concat operator must be surrounded by a single space 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 143 | ERROR | [x] Concat operator must be surrounded by a single space 144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 144 | ERROR | [x] Concat operator must be surrounded by a single space 145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 145 | ERROR | [x] Concat operator must be surrounded by a single space 146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 146 | ERROR | [x] Concat operator must be surrounded by a single space 147 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 147 | ERROR | [x] Concat operator must be surrounded by a single space 147 | ERROR | [x] Concat operator must be surrounded by a single space 147 | ERROR | [x] Concat operator must be surrounded by a single space 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 149 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 149 | ERROR | [x] Concat operator must be surrounded by a single space 150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Concat operator must be surrounded by a single space 151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 151 | ERROR | [x] Concat operator must be surrounded by a single space 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 152 | ERROR | [x] Concat operator must be surrounded by a single space 153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Concat operator must be surrounded by a single space 154 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Concat operator must be surrounded by a single space 155 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 155 | ERROR | [x] Concat operator must be surrounded by a single space 156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 156 | ERROR | [x] Concat operator must be surrounded by a single space 157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 157 | ERROR | [x] Concat operator must be surrounded by a single space 158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 158 | ERROR | [x] Expected 1 space after IF keyword; 0 found 159 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 159 | ERROR | [x] Concat operator must be surrounded by a single space 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 160 | ERROR | [x] Expected newline after closing brace 161 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 161 | ERROR | [x] Concat operator must be surrounded by a single space 162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 163 | ERROR | [x] Concat operator must be surrounded by a single space 164 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 164 | ERROR | [x] Concat operator must be surrounded by a single space 165 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 165 | ERROR | [x] Concat operator must be surrounded by a single space 166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 166 | ERROR | [x] Concat operator must be surrounded by a single space 167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 167 | ERROR | [x] Concat operator must be surrounded by a single space 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 168 | ERROR | [x] Concat operator must be surrounded by a single space 169 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 169 | ERROR | [x] Concat operator must be surrounded by a single space 170 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 170 | ERROR | [x] Expected 1 space after IF keyword; 0 found 171 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 171 | ERROR | [x] Concat operator must be surrounded by a single space 171 | ERROR | [x] Concat operator must be surrounded by a single space 171 | ERROR | [x] Concat operator must be surrounded by a single space 172 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 172 | ERROR | [x] Expected newline after closing brace 173 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 173 | ERROR | [x] Concat operator must be surrounded by a single space 174 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 176 | ERROR | [x] Concat operator must be surrounded by a single space 177 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 177 | ERROR | [x] Concat operator must be surrounded by a single space 177 | ERROR | [x] Concat operator must be surrounded by a single space 177 | ERROR | [x] Concat operator must be surrounded by a single space 178 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 178 | ERROR | [x] Concat operator must be surrounded by a single space 179 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 179 | ERROR | [x] Concat operator must be surrounded by a single space 179 | ERROR | [x] Concat operator must be surrounded by a single space 179 | ERROR | [x] Concat operator must be surrounded by a single space 180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 180 | ERROR | [x] Concat operator must be surrounded by a single space 181 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 181 | ERROR | [x] Concat operator must be surrounded by a single space 181 | ERROR | [x] Concat operator must be surrounded by a single space 181 | ERROR | [x] Concat operator must be surrounded by a single space 182 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 182 | ERROR | [x] Concat operator must be surrounded by a single space 183 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 183 | ERROR | [x] Concat operator must be surrounded by a single space 184 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 184 | ERROR | [x] Concat operator must be surrounded by a single space 185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 185 | ERROR | [x] Concat operator must be surrounded by a single space 186 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 186 | ERROR | [x] Concat operator must be surrounded by a single space 187 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 187 | ERROR | [x] Concat operator must be surrounded by a single space 188 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 188 | ERROR | [x] Concat operator must be surrounded by a single space 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 189 | ERROR | [x] Concat operator must be surrounded by a single space 190 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 190 | ERROR | [x] Concat operator must be surrounded by a single space 191 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 191 | ERROR | [x] Concat operator must be surrounded by a single space 192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 192 | ERROR | [x] Concat operator must be surrounded by a single space 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Concat operator must be surrounded by a single space 194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 194 | ERROR | [x] Concat operator must be surrounded by a single space 195 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 195 | ERROR | [x] Concat operator must be surrounded by a single space 196 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 196 | ERROR | [x] Concat operator must be surrounded by a single space 197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 197 | ERROR | [x] Concat operator must be surrounded by a single space 198 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 198 | ERROR | [x] Concat operator must be surrounded by a single space 199 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 199 | ERROR | [x] Concat operator must be surrounded by a single space 200 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 200 | ERROR | [x] Concat operator must be surrounded by a single space 201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 201 | ERROR | [x] Concat operator must be surrounded by a single space 202 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 202 | ERROR | [x] Concat operator must be surrounded by a single space 203 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 203 | ERROR | [x] Concat operator must be surrounded by a single space 204 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 204 | ERROR | [x] Expected 1 space after IF keyword; 0 found 205 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 205 | ERROR | [x] Concat operator must be surrounded by a single space 206 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 206 | ERROR | [x] Concat operator must be surrounded by a single space 207 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 207 | ERROR | [x] Concat operator must be surrounded by a single space 208 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 208 | ERROR | [x] Concat operator must be surrounded by a single space 209 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 209 | ERROR | [x] Concat operator must be surrounded by a single space 210 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 210 | ERROR | [x] Concat operator must be surrounded by a single space 211 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 211 | ERROR | [x] Concat operator must be surrounded by a single space 212 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 212 | ERROR | [x] Concat operator must be surrounded by a single space 213 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 213 | ERROR | [x] Concat operator must be surrounded by a single space 214 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 214 | ERROR | [x] Concat operator must be surrounded by a single space 215 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 215 | ERROR | [x] Concat operator must be surrounded by a single space 216 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 216 | ERROR | [x] Concat operator must be surrounded by a single space 217 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 217 | ERROR | [x] Concat operator must be surrounded by a single space 218 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 218 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 219 | ERROR | [x] Concat operator must be surrounded by a single space 220 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 220 | ERROR | [x] Concat operator must be surrounded by a single space 221 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 221 | ERROR | [x] Concat operator must be surrounded by a single space 222 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 222 | ERROR | [x] Concat operator must be surrounded by a single space 223 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 224 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 224 | ERROR | [x] Concat operator must be surrounded by a single space 226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 227 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 228 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 229 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 230 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 230 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 231 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 231 | ERROR | [x] Expected newline after closing brace 231 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 232 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 232 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 233 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 233 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 234 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 235 | ERROR | [x] Expected 1 blank line after function; 0 found 236 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 340 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/TestMenuService.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 90 ERRORS AND 18 WARNINGS AFFECTING 79 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 7 | ERROR | [x] When importing a class with "use", do not include a leading \ 8 | WARNING | [x] Unused use statement 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | WARNING | [ ] Property name "$_loadResourceService" should not be prefixed with an underscore to indicate visibility 18 | ERROR | [ ] Class property $_loadResourceService should use lowerCamel naming without underscores 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [ ] Missing short description in doc comment 21 | ERROR | [ ] Missing parameter comment 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 35 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 37 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 38 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Short array syntax must be used to define arrays 42 | WARNING | [x] A comma should follow the last multiline array item. Found: $custom_link 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 47 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 48 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 49 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 51 | WARNING | [x] A comma should follow the last multiline array item. Found: 'testsuite/menu' 52 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 54 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 54 | ERROR | [x] Short array syntax must be used to define arrays 55 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 56 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [ ] Missing parameter comment 66 | ERROR | [ ] Missing parameter name 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [ ] Private method name "TestMenuService::_createName" is not in lowerCamel format 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 84 | ERROR | [x] Short array syntax must be used to define arrays 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Short array syntax must be used to define arrays 86 | WARNING | [ ] Unused variable $linkString. 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | WARNING | [ ] Unused variable $javaScriptUrl. 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 89 | ERROR | [x] Short array syntax must be used to define arrays 90 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 90 | ERROR | [x] Expected 1 space after IF keyword; 0 found 91 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 91 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 92 | ERROR | [x] Short array syntax must be used to define arrays 94 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 94 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 95 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 95 | ERROR | [x] Expected 1 space after IF keyword; 0 found 96 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 28 97 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 98 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 99 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 99 | WARNING | [ ] Only string literals should be passed to t() where possible 105 | WARNING | [x] A comma should follow the last multiline array item. Found: $directory 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 24 110 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 24 113 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 114 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 115 | ERROR | [x] Concat operator must be surrounded by a single space 115 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 115 | WARNING | [ ] Only string literals should be passed to t() where possible 115 | ERROR | [x] Concat operator must be surrounded by a single space 116 | WARNING | [x] A comma should follow the last multiline array item. Found: $directories 118 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 120 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 121 | ERROR | [x] Concat operator must be surrounded by a single space 121 | ERROR | [x] Concat operator must be surrounded by a single space 122 | WARNING | [x] A comma should follow the last multiline array item. Found: $items 124 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 128 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 129 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 130 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 130 | ERROR | [x] Short array syntax must be used to define arrays 131 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 132 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 133 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 137 | ERROR | [x] Expected 1 blank line after function; 0 found 138 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 91 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/ShellExecService.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 101 ERRORS AND 6 WARNINGS AFFECTING 80 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [ ] Missing short description in doc comment 13 | ERROR | [x] Expected "stringTherootpathwhereallshell_execcommandsthatwillrunthephpunitstatementsneedtoberanfrom" but found "string | | The root path where all shell_exec commands that will run the phpunit statements need to be ran from." for @var tag in | | member variable comment 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | WARNING | [ ] Property name "$_rootPath" should not be prefixed with an underscore to indicate visibility 15 | ERROR | [ ] Class property $_rootPath should use lowerCamel naming without underscores 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 21 | ERROR | [x] Expected 1 space after IF keyword; 0 found 22 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | ERROR | [x] Expected newline after closing brace 24 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [ ] Public method name "ShellExecService::GetReportHeading" is not in lowerCamel format 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Short array syntax must be used to define arrays 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 90 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 91 | ERROR | [x] Expected 1 space before "<"; 0 found 91 | ERROR | [x] Expected 1 space after "<"; 0 found 91 | ERROR | [x] Expected 1 space before "+="; 0 found 91 | ERROR | [x] Expected 1 space after "+="; 0 found 92 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 92 | ERROR | [x] Expected 1 space after IF keyword; 0 found 93 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 94 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 95 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 96 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 96 | ERROR | [x] No space found before comment text; expected "// dpm($class);" but found "//dpm($class);" 97 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 97 | ERROR | [x] Expected 1 space after IF keyword; 0 found 98 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 98 | ERROR | [x] Short array syntax must be used to define arrays 100 | WARNING | [x] A comma should follow the last multiline array item. Found: $classCount 102 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 103 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 105 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 106 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 123 | ERROR | [x] Short array syntax must be used to define arrays 124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 129 | ERROR | [x] Expected 1 space before "<"; 0 found 129 | ERROR | [x] Expected 1 space after "<"; 0 found 130 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 148 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 148 | WARNING | [ ] Unused variable $module. 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 149 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 149 | WARNING | [ ] Unused variable $key. 150 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 150 | ERROR | [x] Expected 1 space after IF keyword; 0 found 150 | ERROR | [x] Inline control structures are not allowed 150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 151 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 155 | ERROR | [x] Expected 1 blank line after function; 0 found 156 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 100 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/TestInterface.php ----------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------- 47 | ERROR | Missing parameter comment ----------------------------------------------------------------------------- FILE: /testsuite/src/Form/ConfigurationForm.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 172 ERRORS AND 19 WARNINGS AFFECTING 159 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | WARNING | [ ] Property name "$_initializerService" should not be prefixed with an underscore to indicate visibility 18 | ERROR | [ ] Class property $_initializerService should use lowerCamel naming without underscores 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [ ] Missing short description in doc comment 21 | ERROR | [x] Expected "stringAbsolutepathtobrowseroutputdirectory" but found "string Absolute path to browser output directory." for | | @var tag in member variable comment 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | WARNING | [ ] Property name "$_browserOutputDirectory" should not be prefixed with an underscore to indicate visibility 23 | ERROR | [ ] Class property $_browserOutputDirectory should use lowerCamel naming without underscores 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [ ] Missing short description in doc comment 25 | ERROR | [ ] Parameter $initializerService is not described in comment 26 | ERROR | [ ] Missing parameter comment 26 | ERROR | [ ] Doc comment for parameter $loadResourceService does not match actual variable name $initializerService 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Expected 1 space after IF keyword; 0 found 31 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 32 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 32 | ERROR | [x] Concat operator must be surrounded by a single space 33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 33 | ERROR | [x] Expected newline after closing brace 34 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 35 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 35 | ERROR | [x] Concat operator must be surrounded by a single space 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 60 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 72 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 72 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 73 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 73 | ERROR | [x] Short array syntax must be used to define arrays 74 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 75 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 76 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 78 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 79 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 80 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 86 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 86 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 88 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 89 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 90 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 93 | ERROR | [x] Array indentation error, expected 22 spaces but found 24 95 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 101 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 102 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 103 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 104 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 104 | WARNING | [ ] #description values usually have to run through t() for translation 106 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 109 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 110 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 111 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 112 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 115 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 116 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 117 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 118 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 122 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 123 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 126 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 127 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 128 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 129 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 133 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 134 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 135 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 139 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 140 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 141 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 141 | WARNING | [ ] #description values usually have to run through t() for translation 146 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 149 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 151 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 152 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 152 | WARNING | [ ] #description values usually have to run through t() for translation 158 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 162 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 163 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 164 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 164 | WARNING | [ ] #description values usually have to run through t() for translation 170 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 171 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 172 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 173 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 177 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 178 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 179 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 180 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 180 | WARNING | [ ] #description values usually have to run through t() for translation 185 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 186 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 187 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 188 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 190 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 191 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 192 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 198 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 199 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 200 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 201 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 202 | ERROR | [x] Array indentation error, expected 14 spaces but found 12 203 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 204 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 204 | ERROR | [ ] No key specified for array entry; first entry specifies key 205 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 211 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 212 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 213 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 213 | WARNING | [ ] #description values usually have to run through t() for translation 215 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 218 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 219 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 220 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 221 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 221 | WARNING | [ ] #description values usually have to run through t() for translation 223 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 227 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 228 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 229 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 229 | WARNING | [ ] #description values usually have to run through t() for translation 233 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 235 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 242 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 244 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12 254 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 254 | ERROR | [x] Expected 1 space after IF keyword; 0 found 255 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 256 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 257 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 258 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12 262 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 262 | ERROR | [x] Expected 1 space after IF keyword; 0 found 263 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 263 | ERROR | [x] Expected 1 space after IF keyword; 0 found 264 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 265 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 266 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 267 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 267 | ERROR | [x] Expected newline after closing brace 268 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 268 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 269 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 271 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 273 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 274 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 274 | ERROR | [x] Expected 1 blank line after function; 0 found 275 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 166 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/Form/CustomTestsForm.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 57 ERRORS AND 22 WARNINGS AFFECTING 63 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 23 | ERROR | [ ] Missing short description in doc comment 26 | WARNING | [ ] Property name "$_loadResourceService" should not be prefixed with an underscore to indicate visibility 26 | ERROR | [ ] Class property $_loadResourceService should use lowerCamel naming without underscores 28 | ERROR | [ ] Missing short description in doc comment 31 | WARNING | [ ] Property name "$_testMenuService" should not be prefixed with an underscore to indicate visibility 31 | ERROR | [ ] Class property $_testMenuService should use lowerCamel naming without underscores 33 | ERROR | [ ] Missing short description in doc comment 34 | ERROR | [x] Expected "arrayThearrayoffilestocreateResourcewith" but found "array The array of files to create Resource with." for | | @var tag in member variable comment 36 | WARNING | [ ] Property name "$_loadedFiles" should not be prefixed with an underscore to indicate visibility 36 | ERROR | [ ] Class property $_loadedFiles should use lowerCamel naming without underscores 38 | ERROR | [ ] Missing short description in doc comment 39 | ERROR | [x] Expected "boolIftherearetest" but found "bool If there are test." for @var tag in member variable comment 41 | WARNING | [ ] Property name "$_testsFound" should not be prefixed with an underscore to indicate visibility 41 | ERROR | [ ] Class property $_testsFound should use lowerCamel naming without underscores 41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 43 | ERROR | [ ] Missing short description in doc comment 44 | ERROR | [ ] Missing parameter comment 45 | ERROR | [ ] Missing parameter comment 51 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 53 | ERROR | [x] Expected 1 space after IF keyword; 0 found 54 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 56 | ERROR | [x] Concat operator must be surrounded by a single space 58 | ERROR | [x] Expected 1 space after IF keyword; 0 found 59 | ERROR | [x] Calling class constructors must always include parentheses 60 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 61 | ERROR | [x] Short array syntax must be used to define arrays 66 | ERROR | [x] Concat operator must be surrounded by a single space 71 | ERROR | [x] Expected newline after closing brace 71 | ERROR | [x] Use "elseif" in place of "else if" 72 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 73 | ERROR | [x] Short array syntax must be used to define arrays 74 | WARNING | [x] A comma should follow the last multiline array item. Found: 'No custom tests found.' 76 | ERROR | [x] Expected newline after closing brace 77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 78 | ERROR | [x] Short array syntax must be used to define arrays 79 | WARNING | [x] A comma should follow the last multiline array item. Found: 'Please enable custom_tests module to create custom tests.' 82 | ERROR | [x] Expected newline after closing brace 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 83 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 84 | ERROR | [x] Short array syntax must be used to define arrays 85 | WARNING | [x] A comma should follow the last multiline array item. Found: 'Please copy the custom_tests module into the modules/custom | | folder, rename custom_tests.info.yml.txt to custom_tests.info.yml and enable the module to create and use custom tests.' 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 87 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 6 122 | ERROR | [x] Expected 1 space after IF keyword; 0 found 125 | ERROR | [x] Short array syntax must be used to define arrays 126 | ERROR | [ ] The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines 126 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 128 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 132 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 133 | ERROR | [x] Expected 1 space after IF keyword; 0 found 136 | ERROR | [x] Concat operator must be surrounded by a single space 136 | WARNING | [ ] Only string literals should be passed to t() where possible 136 | ERROR | [x] Concat operator must be surrounded by a single space 138 | ERROR | [x] Expected newline after closing brace 138 | ERROR | [x] Use "elseif" in place of "else if" 138 | ERROR | [x] Expected 1 space after IF keyword; 0 found 141 | ERROR | [x] Concat operator must be surrounded by a single space 141 | WARNING | [ ] Only string literals should be passed to t() where possible 141 | ERROR | [x] Concat operator must be surrounded by a single space 143 | ERROR | [x] Expected newline after closing brace 146 | WARNING | [ ] Only string literals should be passed to t() where possible 147 | ERROR | [x] Short array syntax must be used to define arrays 156 | ERROR | [x] Expected 1 space after IF keyword; 0 found 159 | ERROR | [x] Short array syntax must be used to define arrays 160 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 162 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 170 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 183 | WARNING | [x] A comma should follow the last multiline array item. Found: $container 184 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 185 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 186 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 187 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 197 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 198 | ERROR | [x] Expected 1 space after IF keyword; 0 found 200 | ERROR | [x] Expected 1 space after IF keyword; 0 found 201 | ERROR | [x] Calling class constructors must always include parentheses 209 | ERROR | [x] Expected 1 blank line after function; 0 found 210 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 58 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/Form/PHPUnitTestsForm.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 37 ERRORS AND 22 WARNINGS AFFECTING 42 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 24 | ERROR | [ ] Missing short description in doc comment 27 | WARNING | [ ] Property name "$_loadResourceService" should not be prefixed with an underscore to indicate visibility 27 | ERROR | [ ] Class property $_loadResourceService should use lowerCamel naming without underscores 29 | ERROR | [ ] Missing short description in doc comment 32 | WARNING | [ ] Property name "$_testMenuService" should not be prefixed with an underscore to indicate visibility 32 | ERROR | [ ] Class property $_testMenuService should use lowerCamel naming without underscores 34 | ERROR | [ ] Missing short description in doc comment 37 | WARNING | [ ] Property name "$_initializerService" should not be prefixed with an underscore to indicate visibility 37 | ERROR | [ ] Class property $_initializerService should use lowerCamel naming without underscores 39 | ERROR | [ ] Missing short description in doc comment 40 | ERROR | [x] Expected "arrayThearrayoffilestocreateResourcewith" but found "array The array of files to create Resource with." for | | @var tag in member variable comment 42 | WARNING | [ ] Property name "$_loadedFiles" should not be prefixed with an underscore to indicate visibility 42 | ERROR | [ ] Class property $_loadedFiles should use lowerCamel naming without underscores 44 | ERROR | [ ] Missing short description in doc comment 44 | ERROR | [ ] Parameter $initializerService is not described in comment 45 | ERROR | [ ] Missing parameter comment 46 | ERROR | [ ] Missing parameter comment 95 | ERROR | [x] Short array syntax must be used to define arrays 96 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 98 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 101 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 105 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 106 | ERROR | [x] Concat operator must be surrounded by a single space 106 | ERROR | [x] Concat operator must be surrounded by a single space 106 | ERROR | [x] Concat operator must be surrounded by a single space 106 | ERROR | [x] Concat operator must be surrounded by a single space 110 | WARNING | [ ] Only string literals should be passed to t() where possible 111 | ERROR | [x] Short array syntax must be used to define arrays 121 | WARNING | [ ] Only string literals should be passed to t() where possible 121 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 126 | WARNING | [ ] Only string literals should be passed to t() where possible 126 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 131 | WARNING | [ ] Only string literals should be passed to t() where possible 131 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 136 | ERROR | [x] Short array syntax must be used to define arrays 137 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 139 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 147 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 160 | WARNING | [x] A comma should follow the last multiline array item. Found: $module_menu 166 | WARNING | [x] A comma should follow the last multiline array item. Found: $container 167 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 168 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 169 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 170 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 180 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 181 | ERROR | [x] Expected 1 space after IF keyword; 0 found 182 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 183 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 183 | ERROR | [x] Expected 1 space after IF keyword; 0 found 183 | ERROR | [x] Inline control structures are not allowed 184 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 184 | ERROR | [x] Expected 1 space after IF keyword; 0 found 184 | ERROR | [x] Inline control structures are not allowed 185 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 185 | ERROR | [x] Expected 1 space after IF keyword; 0 found 185 | ERROR | [x] Inline control structures are not allowed 186 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 189 | ERROR | [x] Expected 1 blank line after function; 0 found 190 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/Controller/TestSuiteController.php ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 129 ERRORS AND 14 WARNINGS AFFECTING 101 LINES ----------------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | [ ] Missing short description in doc comment 20 | WARNING | [ ] Property name "$_loadResourceService" should not be prefixed with an underscore to indicate visibility 20 | ERROR | [ ] Class property $_loadResourceService should use lowerCamel naming without underscores 22 | ERROR | [ ] Missing short description in doc comment 25 | WARNING | [ ] Property name "$_testMenuService" should not be prefixed with an underscore to indicate visibility 25 | ERROR | [ ] Class property $_testMenuService should use lowerCamel naming without underscores 27 | ERROR | [ ] Missing short description in doc comment 30 | WARNING | [ ] Property name "$_shellExecService" should not be prefixed with an underscore to indicate visibility 30 | ERROR | [ ] Class property $_shellExecService should use lowerCamel naming without underscores 32 | ERROR | [ ] Missing short description in doc comment 33 | ERROR | [x] Expected "arrayThearrayoffilestocreateResourcewith" but found "array The array of files to create Resource with." for | | @var tag in member variable comment 35 | WARNING | [ ] Property name "$_loadedFiles" should not be prefixed with an underscore to indicate visibility 35 | ERROR | [ ] Class property $_loadedFiles should use lowerCamel naming without underscores 40 | ERROR | [ ] Missing parameter comment 41 | ERROR | [ ] Missing parameter comment 42 | ERROR | [ ] Missing parameter comment 68 | ERROR | [ ] Missing parameter comment 75 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 77 | ERROR | [x] Concat operator must be surrounded by a single space 79 | ERROR | [x] Expected 1 space after IF keyword; 0 found 80 | ERROR | [x] Calling class constructors must always include parentheses 81 | ERROR | [x] Short array syntax must be used to define arrays 86 | ERROR | [x] Concat operator must be surrounded by a single space 91 | ERROR | [x] Short array syntax must be used to define arrays 93 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 96 | ERROR | [x] Short array syntax must be used to define arrays 97 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 99 | ERROR | [x] Expected 1 space after IF keyword; 0 found 100 | ERROR | [x] Short array syntax must be used to define arrays 102 | WARNING | [x] A comma should follow the last multiline array item. Found: $results 107 | ERROR | [x] Short array syntax must be used to define arrays 110 | ERROR | [x] Short array syntax must be used to define arrays 112 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 117 | ERROR | [x] Short array syntax must be used to define arrays 117 | ERROR | [x] Short array syntax must be used to define arrays 120 | ERROR | [x] Closing parenthesis of array declaration must be on a new line 129 | WARNING | [x] A comma should follow the last multiline array item. Found: 'test-suite-table' 130 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 131 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 140 | ERROR | [ ] Missing parameter comment 152 | ERROR | [x] Short array syntax must be used to define arrays 153 | ERROR | [x] Short array syntax must be used to define arrays 155 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 158 | ERROR | [x] Expected 1 space after IF keyword; 0 found 158 | ERROR | [x] Inline control structures are not allowed 161 | ERROR | [x] Short array syntax must be used to define arrays 164 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 164 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 171 | ERROR | [x] Expected 1 space before "<"; 0 found 171 | ERROR | [x] Expected 1 space after "<"; 0 found 173 | ERROR | [x] Concat operator must be surrounded by a single space 173 | ERROR | [x] Concat operator must be surrounded by a single space 174 | ERROR | [x] Concat operator must be surrounded by a single space 174 | ERROR | [x] Concat operator must be surrounded by a single space 177 | ERROR | [x] Expected 1 space after IF keyword; 0 found 180 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 181 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 182 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 182 | ERROR | [x] Expected 1 space before "<"; 0 found 182 | ERROR | [x] Expected 1 space after "<"; 0 found 184 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 185 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 185 | ERROR | [x] Concat operator must be surrounded by a single space 185 | ERROR | [x] Concat operator must be surrounded by a single space 186 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 186 | ERROR | [x] Concat operator must be surrounded by a single space 186 | ERROR | [x] Concat operator must be surrounded by a single space 187 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 188 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 190 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 191 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 191 | ERROR | [x] Expected 1 space after IF keyword; 0 found 192 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 192 | ERROR | [x] Expected 1 space before "<"; 0 found 192 | ERROR | [x] Expected 1 space after "<"; 0 found 194 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 195 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 195 | ERROR | [x] Concat operator must be surrounded by a single space 195 | ERROR | [x] Concat operator must be surrounded by a single space 196 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 198 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 199 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 200 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 205 | ERROR | [x] Expected 1 space after IF keyword; 0 found 210 | ERROR | [x] Short array syntax must be used to define arrays 212 | WARNING | [x] A comma should follow the last multiline array item. Found: $table 217 | ERROR | [ ] Parameter $area is not described in comment 217 | ERROR | [ ] Parameter $module is not described in comment 217 | ERROR | [ ] Parameter $directory is not described in comment 217 | ERROR | [ ] Parameter $file is not described in comment 220 | ERROR | [ ] Missing parameter comment 220 | ERROR | [ ] Doc comment for parameter $request does not match actual variable name $file 225 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 227 | ERROR | [x] Expected 1 space after IF keyword; 0 found 227 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 229 | ERROR | [x] Expected newline after closing brace 233 | ERROR | [x] Short array syntax must be used to define arrays 234 | ERROR | [x] Short array syntax must be used to define arrays 238 | ERROR | [x] Expected 1 space after IF keyword; 0 found 238 | ERROR | [x] Inline control structures are not allowed 241 | ERROR | [x] Short array syntax must be used to define arrays 244 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 244 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 250 | ERROR | [x] Expected 1 space before "<"; 0 found 250 | ERROR | [x] Expected 1 space after "<"; 0 found 252 | ERROR | [x] Concat operator must be surrounded by a single space 252 | ERROR | [x] Concat operator must be surrounded by a single space 253 | ERROR | [x] Concat operator must be surrounded by a single space 253 | ERROR | [x] Concat operator must be surrounded by a single space 256 | ERROR | [x] Expected 1 space after IF keyword; 0 found 259 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 260 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 261 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 261 | ERROR | [x] Expected 1 space before "<"; 0 found 261 | ERROR | [x] Expected 1 space after "<"; 0 found 263 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 264 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 264 | ERROR | [x] Concat operator must be surrounded by a single space 264 | ERROR | [x] Concat operator must be surrounded by a single space 265 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 265 | ERROR | [x] Concat operator must be surrounded by a single space 265 | ERROR | [x] Concat operator must be surrounded by a single space 266 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 267 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 269 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 270 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 270 | ERROR | [x] Expected 1 space after IF keyword; 0 found 271 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 271 | ERROR | [x] Expected 1 space before "<"; 0 found 271 | ERROR | [x] Expected 1 space after "<"; 0 found 273 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 274 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 274 | ERROR | [x] Concat operator must be surrounded by a single space 274 | ERROR | [x] Concat operator must be surrounded by a single space 275 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 277 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 278 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 279 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 284 | ERROR | [x] Expected 1 space after IF keyword; 0 found 289 | ERROR | [x] Short array syntax must be used to define arrays 291 | WARNING | [x] A comma should follow the last multiline array item. Found: $table 294 | ERROR | [x] Expected 1 blank line after function; 0 found 295 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 120 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /testsuite/src/BaseService.php ----------------------------------------------------------------------------------------------- FOUND 9 ERRORS AND 1 WARNING AFFECTING 8 LINES ----------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 5 | WARNING | [x] Unused use statement 15 | ERROR | [ ] Description for the @return value is missing 19 | ERROR | [x] Inline control structures are not allowed 19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 20 | ERROR | [x] Inline control structures are not allowed 20 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 26 | ERROR | [ ] Description for the @return value is missing 30 | ERROR | [x] Expected 1 blank line after function; 0 found 31 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: /testsuite/src/GuzzleService.php ------------------------------------------------------------------------------------------------------------------ FOUND 17 ERRORS AND 1 WARNING AFFECTING 12 LINES ------------------------------------------------------------------------------------------------------------------ 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [ ] Missing short description in doc comment 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | WARNING | [ ] Property name "$_httpClient" should not be prefixed with an underscore to indicate visibility 15 | ERROR | [ ] Class property $_httpClient should use lowerCamel naming without underscores 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [ ] Missing parameter comment 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Expected 1 blank line before function; 2 found 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Expected 1 blank line after function; 0 found 34 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: /testsuite/tests/src/Functional/UiPageTest.php ------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 40 | ERROR | [x] Expected 1 blank line after function; 0 found 41 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /testsuite/tests/src/Unit/GuzzleServiceTest.php --------------------------------------------------------------------------------------------------------------------- FOUND 20 ERRORS AND 2 WARNINGS AFFECTING 16 LINES --------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [ ] Missing short description in doc comment 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | WARNING | [ ] Property name "$_guzzleService" should not be prefixed with an underscore to indicate visibility 13 | ERROR | [ ] Class property $_guzzleService should use lowerCamel naming without underscores 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | WARNING | [ ] Property name "$_httpClient" should not be prefixed with an underscore to indicate visibility 20 | ERROR | [ ] Class property $_httpClient should use lowerCamel naming without underscores 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Expected 1 newline at end of file; 0 found 37 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- - 🇺🇸United States trigve hagen Washington DC
Hey thanks for the input on this. Can you please tell me how you configures phpcs and phpcbf because after installing and setting it all up I get conflicting reports between VScode terminal and the intel in the editor itself. When the editor reports it is good(No errors) the terminal reports a ton of errors and visa versa. I need to get this going for work. I work for the Gov @ Department of the Inspector General and this is for work. I looked over other plugins in contrib and all of them are failing. Is this something new you are implementing? Thanks.
- 🇩🇪Germany Grevil
@Trigve Hagen, take a look at https://www.drupal.org/docs/develop/development-tools/editors-and-ides/c... → !
- 🇺🇸United States trigve hagen Washington DC
Hey buddy. I finished up the tasks. Hows it look? Thanks
- Status changed to Needs review
over 1 year ago 10:07am 9 August 2023 - Status changed to Needs work
over 1 year ago 10:07am 9 August 2023 - 🇮🇳India vishal.kadam Mumbai
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml testsuite/ FILE: testsuite/testsuite.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: testsuite/testsuite.links.menu.yml ------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------ 13 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: testsuite/tests_module/custom_tests/custom_tests.info.yml.txt -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 90 characters -------------------------------------------------------------------------------- FILE: testsuite/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 443 characters 20 | WARNING | Line exceeds 80 characters; contains 527 characters 25 | WARNING | Line exceeds 80 characters; contains 585 characters 30 | WARNING | Line exceeds 80 characters; contains 439 characters 32 | WARNING | Line exceeds 80 characters; contains 311 characters ---------------------------------------------------------------------- FILE: testsuite/src/Form/PHPUnitTestsForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 14 | ERROR | Class name doesn't match filename; expected "class PHPUnitTestsForm" -------------------------------------------------------------------------------- FILE: testsuite/src/ShellExecService.php ------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------ 149 | WARNING | Unused variable $module. 150 | WARNING | Unused variable $key. ------------------------------------------------------------------------ FILE: testsuite/css/testsuite_menu.css -------------------------------------------------------------------------------- FOUND 101 ERRORS AFFECTING 97 LINES -------------------------------------------------------------------------------- 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] CSS colours must be defined in lowercase; expected #eeeeee but found #EEEEEE 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 167 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 190 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 101 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: testsuite/testsuite.module ------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------ 5 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 8 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 9 | WARNING | [ ] There must be no blank line following an inline comment 9 | ERROR | [x] Inline comments must start with a capital letter 9 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 22 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 29 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ) ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ - 🇺🇸United States trigve hagen Washington DC
Got them fixed. Should be ready now.
- 🇮🇳India vishal.kadam Mumbai
Fix phpcs issue.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml testsuite/
FILE: testsuite/src/Form/PHPUnitTestsForm.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
14 | ERROR | Class name doesn't match filename; expected "class PHPUnitTestsForm"
----------------------------------------------------------------------------------- - 🇮🇳India vishal.kadam Mumbai
Rest looks fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
- Status changed to Needs review
over 1 year ago 10:22am 24 August 2023 - Status changed to RTBC
about 1 year ago 11:36am 23 September 2023 - Status changed to Needs work
about 1 year ago 8:44pm 23 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- What follows is a quick review of the project; it doesn't mean to be complete
- For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
- A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance
src/Controller/TestSuiteController.php
$table = '<table class="test-suite-table responsive-enabled">'; $table .= '<thead><tr><th>Name</th><th>Results</th><th>Actions</th></tr></thead>'; for ($i = 0; $i < count($result); $i++) { $table .= '<tr class="test-suite-test-report-rows">'; $table .= '<td>' . $result[$i]['name'] . '</td>'; $table .= '<td width="50%">' . $result[$i]['results'] . '</td>'; $table .= '<td><a href="#" class="button button--primary test-suite-table-row-show-button">Show Report</a></td>'; $table .= '</tr>'; if (isset($classArray[$result[$i]['module']])) { $table .= '<tr class="test-suite-test-report-table-rows">'; $table .= '<td class="test-suite-test-report-table-columns" colspan="3">'; $table .= '<table class="test-suite-table responsive-enabled">'; $table .= '<thead><tr><th>Class Name</th><th>Tests Ran</th><th>Results</th></tr></thead>'; for ($j = 0; $j < count($classArray[$result[$i]['module']]); $j++) { $table .= '<tr>'; $table .= '<td>' . $classArray[$result[$i]['module']][$j]['class'] . '</td>'; $table .= '<td>' . $classArray[$result[$i]['module']][$j]['count'] . '</td>'; $table .= '<td>Tested.</td>'; $table .= '</tr>'; } if (isset($errorArray[$result[$i]['module']])) { for ($j = 0; $j < count($errorArray[$result[$i]['module']]); $j++) { $table .= '<tr>'; $table .= '<td colspan="3">' . $errorArray[$result[$i]['module']][$j] . '</td>'; $table .= '</tr>'; } } $table .= '</table>'; $table .= '</td></tr>'; } } if (empty($result)) { $table .= '<tr><td colspan="3">There are no results yet.</td></tr>'; } $table .= '</table>'; $output['table'] = [ '#type' => 'markup', '#markup' => $table, ];The code is rendering complex markup using #markup, which is thought for simple markup. For complex markup #theme or #type should be used.
src/TestInterface.php
/** * Gets the module name. * * @return bool * The module name. */ public function getModuleName();If it returns the module name, it cannot return a Boolean value.
/** * Gets the test name. * * @return bool * If the test succeeded or failed. */ public function getName(); /** * Gets the test description. * * @return bool * If the test succeeded or failed. */ public function getDescription();The method description does not match with the return value description.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I am changing priority as per Issue priorities → .
- 🇺🇸United States trigve hagen Washington DC
Ive finished the security fixed and I'm ready for review again. Thanks
- Status changed to Needs review
12 months ago 3:37pm 5 January 2024 - Status changed to Needs work
11 months ago 3:39pm 10 January 2024 - 🇮🇳India vishal.kadam Mumbai
Inconsistent drupal core requirement
FILE: composer.json
"require": { "drupal/core": "^10" },FILE: testsuite.info.yml
core_version_requirement: ^10 || ^11 - Status changed to Needs review
11 months ago 4:33pm 10 January 2024 - 🇺🇸United States trigve hagen Washington DC
I realy need this for work on a .gov site. Thanks
- 🇺🇸United States trigve hagen Washington DC
Ready for Review. Thanks. Do I need to do anything else?
- 🇺🇸United States cmlara
@Trigve Hagen
Per https://www.drupal.org/node/539608#s-application-review-timelines → the priority should be Normal as the issue has only been in needs-review for 7 days (prior to the 7 day mark it should have been minor as the issue had been waiting in 'needs work' for over 5 weeks).Perhaps you want to follow the procedure discussed in
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → to 'boost' your position, and perhaps learn more about writing secure code along the way? There are a number of other applications that have been waiting in needs review longer than your application has that could use some help moving forward. - Status changed to Needs work
11 months ago 10:06am 26 January 2024 - 🇸🇮Slovenia slogar32
I reviewed the module code, here are my findings:
- FILE: testsuite.module
/** * @file * This module provides tests that can be ran from the admin. */The description for a module is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
- The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
/** * Constructs a new TestSuiteController. * * @param object $loadResourceService * Drupal\testsuite\LoadResourceService. * @param object $testMenuService * Drupal\testsuite\TestMenuService. * @param object $shellExecService * Drupal\testsuite\ShellExecService. */ public function __construct( LoadResourceService $loadResourceService, TestMenuService $testMenuService, ShellExecService $shellExecService ) { $this->testMenuService = $testMenuService; $this->loadResourceService = $loadResourceService; $this->shellExecService = $shellExecService; }Function and method declarations are written on a single line.
So the above example should be something like:public function __construct(LoadResourceService $loadResourceService, TestMenuService $testMenuService, ShellExecService $shellExecService) { $this->testMenuService = $testMenuService; $this->loadResourceService = $loadResourceService; $this->shellExecService = $shellExecService; }If you want to keep the documentation comment with the corrected format. Don't forget to do this for all the constructors in the module.
- I would also suggest that you don't use
objectfor the @param descriptions in documentation comments, but instead the actual class/type of the parameter
/** * Builds the report for custom tests. * * @param object $request * Symfony\Component\HttpFoundation\Request. * * @return array * The page as a render array. */ public function customReport(Request $request)should be
/** * Builds the report for custom tests. * * @param \Symfony\Component\HttpFoundation\Request $request * The incoming HTTP request object. * * @return array * The page as a render array. */ public function customReport(Request $request)It then makes sense for the @param description not to be the actual namescape with the class name, but an actual description (doesn't need to be same as in the example that I gave above).
You have it like this in theTestInterface.php, but you are missing the \ in front of the class with the namespace in the @param comment, it should be like this::/** * Runs the test and returns if the test succeeded or failed. * * @param \Symfony\Component\HttpFoundation\Request $request * The request object. * * @return string * Success or Test Passed if the test succeeded. * Failed and the eroors if the test failed. */ public function runTest(Request $request);Please check, that all of your @param in documentation comments are consistent, another example that should be fixed here in
GuzzleService.php:/** * GuzzleService constructor. * * @param \Guzzle\ClientInterface $httpClient * The guzzle client. */ public function __construct(ClientInterface $httpClient) { $this->httpClient = $httpClient; }Should be:
/** * Constructs a new GuzzleService object. * * @param \GuzzleHttp\ClientInterface $httpClient * The guzzle client. */ public function __construct(ClientInterface $httpClient) { $this->httpClient = $httpClient; } - The functions should have parameters type declarations and return type declarations. Somewhere you have the @return tag in the documentation comment and somewhere not, that should also be consistent (I would add @return tags everywhere, except for void returning functions, it is not needed there)
/** * Builds the report for phpunit tests that are accessable through links. * * @param string $area * The area of the module. Core, contrib or custom. * @param string $module * The module. * @param string $directory * The phpunit test directory. Unit, Functional, Kernel etc. * @param string $file * The phpunit test file name. * * @return array * The page as a render array. */ public function phpUnitFileReport($area, $module, $directory, $file = NULL)should be:
/** * Builds the report for phpunit tests that are accessable through links. * * @param string $area * The area of the module. Core, contrib or custom. * @param string $module * The module. * @param string $directory * The phpunit test directory. Unit, Functional, Kernel etc. * @param null|string $file * The phpunit test file name. * * @return array * The page as a render array. */ public function phpUnitFileReport(string $area, string $module, string $directory, ?string $file = NULL): array - There are also some code duplications, you should extract that as a function, for example: in
TestSuiteController.phplines 281-300 are duplicated in lines 187-206 and lines 303-317 are duplicated in 209-223, both of these duplications could be one function. Also inConfigurationForm.php, you have the same line twice in lines 351 and 352. - Class properties should have type declarations. Those should be interfaces, where possible. Also when they are injected in the class, in the documentation comment @param type, and in the actual constructor function parameter type declaration it should be an interface where possible. For example:
/** * Drupal\Core\Messenger\Messenger. * * @var object */ protected $messenger; /** * The path to the phpunit.xml.dist file. * * @var string */ protected $phpunitXmlDistPath;should be:
/** * The messenger service. * * @var \Drupal\Core\Messenger\MessengerInterface */ protected MessengerInterface $messenger; /** * The path to the phpunit.xml.dist file. * * @var string */ protected string $phpunitXmlDistPath;and in the constructor:
/** * Initializer Service constructor. */ public function __construct(MessengerInterface $messenger) { $this->messenger = $messenger; if ($this->isWindows()) { $this->phpunitCore = dirname(dirname(dirname(dirname(__DIR__)))) . '\core'; $this->simpleTestPath = dirname(dirname(dirname(dirname(__DIR__)))) . '\sites\simpletest'; $this->phpunitXmlDistPath = dirname(dirname(dirname(dirname(__DIR__)))) . '\core\phpunit.xml.dist'; $this->phpunitXmlPath = dirname(dirname(dirname(dirname(__DIR__)))) . '\core\phpunit.xml'; } else { $this->phpunitCore = dirname(dirname(dirname(dirname(__DIR__)))) . '/core'; $this->simpleTestPath = dirname(dirname(dirname(dirname(__DIR__)))) . '/sites/simpletest'; $this->phpunitXmlDistPath = dirname(dirname(dirname(dirname(__DIR__)))) . '/core/phpunit.xml.dist'; $this->phpunitXmlPath = dirname(dirname(dirname(dirname(__DIR__)))) . '/core/phpunit.xml'; } }. And when I just posted this example, you can probably replace the dirname nesting with the
DIRECTORY_SEPARATORconstant, if you used this because of multi OS support, then just use the levels parameter of the dirname function instead of nesting it like this.
- Services with public methods should have interfaces implemented. When those classes are used in dependency injection, use the interface.
- There are some typos in your documentation comments like "Builds the report for phpunit tests that are accessable through links." But this is not critical at all, just pointing it out, because it is a quick fix (should be accessible instead of accessable).
This is a full review of the code, when all of this is fixed I see no reason why this shouldn't be in the RBTC status. Please fix all of the occurrences of the issues mentioned above, I've just put some examples in the list. After you do this run phpcs again for Drupal and DrupalPractice standards. If you have any questions or need some help with the fixes just contact me directly on one of the platforms on my profile.
- FILE: testsuite.module
- Status changed to Needs review
11 months ago 11:19am 26 January 2024 - 🇺🇸United States trigve hagen Washington DC
If these are just suggestions I would like to keep my code as is. Thanks.
- 🇸🇮Slovenia slogar32
Those are suggestions for better code, but I think numbers 1 and 2 are needed to pass this validation here, since those are direct Drupal standards (those two are quick fixes also). Depends on the people who have roles to confirm you for the opt-in validation. Good luck in any case!
- 🇺🇸United States trigve hagen Washington DC
I adjusted the duplicated code. I also adjusted MessengerInterface. And I adjusted the comments. The @file, core modules uses a description of what the module does. Check automated_cron, ban, basic_auth, big_pipe, etc.. Im just following their lead. Thanks for the review.
- Status changed to Needs work
11 months ago 5:21pm 26 January 2024 - 🇺🇸United States cmlara
@Trigve Hagen:
From #40.6: Is there a reason you are making recursive dirname calls and are not using
DIRECTORY_SEPARATORfor path access?dirname(dirname(dirname(dirname(__DIR__)))) . '\sites\simpletest'Removing PAreview Bonus as it has been utilized for the #40 review. You may review another batch of applications to set the bonus tag again (and keep it for the remainder) see https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
- Status changed to Needs review
11 months ago 10:33am 1 February 2024 - 🇺🇸United States trigve hagen Washington DC
Updated code to use DIRECTORY_SEPARATOR. Finished 2 more reviews. Thanks.
- Status changed to Needs work
11 months ago 3:59am 2 February 2024 - 🇺🇸United States cmlara
I have reached out directly to the applicant via email with a question.
This issue should remain in needs work until further notice.
- Status changed to Needs review
10 months ago 9:26am 8 February 2024 - 🇺🇸United States cmlara
The above change of status was made after informing the applicant concerns still exist. However as the high level fault appears (on a cursory review) to have been solved I am not moving the issue back to needs work.
The majority of the technical details are currently being withheld following a standard 30 day after resolution disclosure policy.
Without going into technical details, I am concerned, based on interactions with the applicant and a cursory review of the code, that the applicant may not have a sufficiently firm grasp of native PHP Functions and Drupal API which would hinder their ability to write secure PHP code.
- 🇺🇸United States trigve hagen Washington DC
I was in a rush to get this done for work. I overlooked that detail in hast. Definitely will slow down a bit so as not to repeat this. Thanks.
- Status changed to Needs work
10 months ago 1:56pm 14 February 2024 - 🇺🇸United States trigve hagen Washington DC
Ive been doing an extensive remodel on this project that will be done in a couple of days. Adding phpcs and phpstan alongside phpunit. Also building all three as report pages with filter forms. Also adding databases for each one. There is no use leaving this in this category for now. Moving to needs work. Thanks.
- 🇺🇸United States trigve hagen Washington DC
At this website you can find a list of known software that have had security vulnerabilities. We are all in a state of constant development working to secure our code. Composer has one. I'm going to use this API in creating a vulnerability scan for software package too in the testsuite.
Government vulnerability API SourceCVE-2024-24821 - Composer is a dependency Manager for the PHP language. In affected versions several files within the local working directory are included during the invocation of Composer and in the context of the executing user. As such, under certain conditions... read CVE-2024-24821
Published: February 08, 2024; 7:15:08 PM -0500 - Status changed to Needs review
10 months ago 6:35pm 22 February 2024 - 🇺🇸United States trigve hagen Washington DC
Ive finished work on the dev branch @ composer require 'drupal/testsuite:3.0.x-dev@dev'. Should I make a release or wait for you to validate the code base? I didn't realize I could wait before or I would have. Thanks.
- 🇺🇸United States cmlara
Public Followup to #48 Remote Code Exploit discovered in code.
Note: this is only a partial review of the code between commits 856ea365..c5586106. Reviewers should check to see if any of the concerns below still exist or have been duplicated in the code as it appears the project has had a major re-write since initial reports.
On February 1st the maintainer was contacted via email to determine if it would be an appropriate location to discuss the details. After confirmation by the maintainer they were informed that the module appears to be vulnerable to a Remote Code Execution exploit via a GET request to the testsuite.phpunit_file_report route.
A user with the 'access site reports' permission could visit
admin/testsuite/phpunit/file/report/custom/anything/%3Btouch%20vulnerable.txt.Upon request Drupal Core would call TestSuiteController::phpUnitFileReport() with the parameters from the GET request. There was no filtering of the the data provided in the GET request allowing arbitrary additions.
TestSuiteController::phpUnitFileReport() would call LoadResourceService::getStatment() to obtain a command statement and assign the result to $statement.
The sample request would create a $statement string of
'vendor/bin/phpunit --debug -c web/core web/modules/custom/anything/tests/src/;touch vulnerable.txt'When executed on a *nix system two commands would execute, the first for PHPUnit against a directory, and the second to create a "vulnerable.txt" file.
TestSuiteContoller would next call $this->shellExecService->getData($statement) which directly called PHP's shell_exec($statement).
Sequence of discussion and fixes occurred as follows:
- Applicant committing and publishing a new release that changed the required permission for the route to 'administer site pages". This permission is considered less restrictive than the previous restriction.
- Applicant soon after realizing the 'administer site pages' permission. is considered a less privileged permission than 'access site reports'.
- Applicant committing and publishing a new release requiring the 'administer site configuration'
- Applicant than added route parameter restrictions. This to my knowledge stopped immediate exploit. Note: this is the start of the 30 day counter as the release was published and disclosed by the maintainer.
- I notified the applicant the fix above having stopped immediate exploit still left areas unprotected, specifically that calling getStatment() directly would still allow an exploitable result to be called. This left concerns that future faults may re-occur.
- In the following days applicant added basic regex validation inside getStatment()
- I notified applicant that the regex protections added still allowed bypass.
- Applicant in response moved this issue to "Needs Review'.
- I notified applicant again that their code did not prevent all exploits.
- At no time did the maintainer request clarification of the remaining exploit paths choosing instead to try and push through this application process.
Mitigating factors:
A user must have the 'access site reports' permission which is considered a 'trusted' role. However nowhere is it indicated that this role could execute code on the server.Absent from the fixes was:
Any use of escapeshellcmd() even though the helper method takes an arbitrarily formatted executable command.
Any use of escapeshellarg() to reduce the risk of errors in code propagating through to exploitable commands.At no time did the maintainer consult on their fixes prior to publication.
At the time of the 'final commit' getStatment() could be called with
$filePath = '/some/path/;touch vulnerable.txt;'as the preg_match() check contained no start/end of line restrictions allowing a vulnerable command to be generated however there was no currently known exploit path beyond nonresistant contrib extension.As the applicant did not discuss the above use of public methods to generate possibly exploitable calls care should be taken to validate that the applicant has not reproduced such issues during the rework of the code.
I would encourage the reviewers to ensure the applicant does indeed show a knowledge of writing Secure PHP code and adhering to the Drupal API without being prompted.
Note: This report includes information on unfixed concerns as the maintainer has already published their 'completed' fix and initial vulnerability disclosure. The maintainer provided no indication they intended to perform more directly related with the information they had been given. The unfixed concerns directly related to the initial concerns provided to the maintainer and were considered to be covered under the 30 day publication delay.
Adding the 'PAreview: security' tag to indicate that this application revealed a security concern. This tag should not be removed as it is used for statistical tracking.
- 🇺🇸United States trigve hagen Washington DC
cmlara, Can you please get a hold of me to fix this. I have been waiting for your response. I'm willing to do whatever we need to fix this. Thanks
- 🇺🇸United States trigve hagen Washington DC
Added a fix for the regex in all calls that passed parameters to the getData function. Added the ^ at the beginning and the $ at the end. Updated the getData function with the escapeshellcmd() function. Will also add escapeshellarg() to all parameters. Also did some repairs to the phpunit_tests Functional phpunit test and report table. Ill have the escapeshellarg() to all parameters done by the end of the weekend. I will also spend some time testing this weekend to confirm the changes are working properly.
- Status changed to Needs work
7 months ago 10:13pm 22 May 2024 $ ./pareview.sh https://git.drupalcode.org/project/testsuite 3.0.xReview of the 3.0.x branch (commit 0227b7f):
- Your README.md does not follow best practices (headings need to be uppercase). See
https://www.drupal.org/node/2181737 →
.
- The INTRODUCTION section is missing.
- The CONFIGURATION section is missing.
- Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
- The list_packages.module does not implement
hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... → . - ./modules/list_packages/list_packages.admin.inc: All functions should be prefixed with your module/theme name (list_packages) to avoid name clashes. See
https://www.drupal.org/node/318#naming →
function list_libraries_filters() { function list_modules_filters() { function list_module_libraries_filters() { function list_core_libraries_filters() { function comparator($object1, $object2) { - Bad line endings were found, always use unix style terminators. See
https://www.drupal.org/coding-standards#indenting →
./css/filter_forms.css: ASCII text, with CRLF line terminators css/filter_forms.css - Coder Sniffer → has found some issues with your code (please check the Drupal coding standards → ). See attachment.
- Stylelint has found some issues with your code (please check the CSS coding standards → ). See attachment.
-
DrupalPractice →
has found some issues with your code, but could be false positives.
FILE: ...eview_temp/modules/list_packages/src/ListPackagesResourceService.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 420 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead 421 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead -------------------------------------------------------------------------- FILE: testsuite.module ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 26 | WARNING | Unused variable $reqVariables. ---------------------------------------------------------------------- Time: 686ms; Memory: 14MB - PHPStan has found some issues with your code). See attachment.
FILE: .../pareviewsh/pareview_temp/modules/list_packages/list_packages.module -------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------- 11 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 12 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found 13 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found 14 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found 15 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found 16 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: ...pareviewsh/pareview_temp/modules/list_packages/list_packages.install -------------------------------------------------------------------------- FOUND 2 ERRORS AND 20 WARNINGS AFFECTING 22 LINES -------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 39 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 2 45 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 109 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 149 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 2 155 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 219 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 259 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 2 265 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 329 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 374 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 1 380 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 2 386 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 450 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 490 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 1 496 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 2 502 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 566 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 650 | WARNING | [x] A comma should follow the last multiline array item. | | Found: FALSE 655 | WARNING | [x] A comma should follow the last multiline array item. | | Found: FALSE 689 | ERROR | [x] Short array syntax must be used to define arrays 693 | WARNING | [x] A comma should follow the last multiline array item. | | Found: 0 -------------------------------------------------------------------------- PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: ...areviewsh/pareview_temp/modules/list_packages/list_packages.info.yml -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------- FILE: ...pareviewsh/pareview_temp/modules/phpunit_tests/phpunit_tests.install -------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------- 169 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 170 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: ...areviewsh/pareview_temp/modules/phpunit_tests/phpunit_tests.info.yml -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------- FILE: ...ts/pareviewsh/pareview_temp/modules/phpcs_tests/phpcs_tests.info.yml -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------- FILE: ...cts/pareviewsh/pareview_temp/modules/phpcs_tests/phpcs_tests.install -------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------- 78 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found 79 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: ...areviewsh/pareview_temp/modules/phpstan_tests/phpstan_tests.info.yml -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------- FILE: ...pareviewsh/pareview_temp/modules/phpstan_tests/phpstan_tests.install -------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------- 77 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found 78 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: testsuite.install ---------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ---------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 3 | WARNING | [x] Unused use statement 68 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found 69 | ERROR | [x] Expected 1 space(s) before asterisk; 2 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: css/claro_theme.css ------------------------------------------------------------------------ FOUND 13 ERRORS AFFECTING 13 LINES ------------------------------------------------------------------------ 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 7 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ------------------------------------------------------------------------ PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: css/filter_forms.css -------------------------------------------------------------------------- FOUND 9 ERRORS AFFECTING 9 LINES -------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but | | found "\r\n" 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 -------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: css/seven_theme.css ------------------------------------------------------------------------ FOUND 26 ERRORS AFFECTING 26 LINES ------------------------------------------------------------------------ 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 ------------------------------------------------------------------------ PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: testsuite.info.yml -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------- Time: 809ms; Memory: 16MB------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ Line pareview_temp/modules/list_packages/src/Controller/ListCoreLibrariesController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 129 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 263 Method Drupal\list_packages\Controller\ListCoreLibrariesController::createName() should return string but return statement is missing. 395 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 416 Variable $filter_where might not be defined. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ Line pareview_temp/modules/list_packages/src/Controller/ListDashboardController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 89 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 534 Variable $route might not be defined. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ Line pareview_temp/modules/list_packages/src/Controller/ListLibrariesController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 155 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 505 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 518 Variable $filter_where in empty() always exists and is not falsy. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ Line pareview_temp/modules/list_packages/src/Controller/ListModulesController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 251 Method Drupal\list_packages\Controller\ListModulesController::createName() should return string but return statement is missing. 273 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 666 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 679 Variable $filter_where in empty() always exists and is not falsy. 709 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ Line pareview_temp/modules/list_packages/src/Controller/ListPackagesController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ 130 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 392 File list_packages.admin.inc could not be loaded from Drupal\Core\Extension\ModuleHandlerInterface::loadInclude because list_packages module is not found. 405 Variable $filter_where in empty() always exists and is not falsy. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------ ------ -------------------------------------------------------------------- Line pareview_temp/modules/list_packages/src/Form/LoadModsThemsForm.php ------ -------------------------------------------------------------------- 177 Class Drupal referenced with incorrect case: DRUPAL. ------ -------------------------------------------------------------------- ------ ------------------------------------------------------------------- Line pareview_temp/modules/list_packages/src/Form/LoadPackagesForm.php ------ ------------------------------------------------------------------- 129 Variable $packages in isset() always exists and is not nullable. ------ ------------------------------------------------------------------- ------ ---------------------------------------------------------------------------------------------------------------------------------- Line pareview_temp/modules/list_packages/src/ListPackagesResourceService.php ------ ---------------------------------------------------------------------------------------------------------------------------------- 244 Variable $version in isset() always exists and is not nullable. 250 Variable $vulnerabilitiesInfo in isset() always exists and is not nullable. 409 Variable $packageData might not be defined. 420 \Drupal calls should be avoided in classes, use dependency injection instead 421 \Drupal calls should be avoided in classes, use dependency injection instead 588 Variable $newLibraries might not be defined. 646 \Drupal calls should be avoided in classes, use dependency injection instead 759 Method Drupal\list_packages\ListPackagesResourceService::createVulnerabilityArrayGithub() invoked with 2 parameters, 1 required. ------ ---------------------------------------------------------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------- Line pareview_temp/modules/phpcs_tests/src/Form/PhpcsTestsRunTestsMultistepForm.php ------ -------------------------------------------------------------------------------- 359 Variable $types might not be defined. 607 Variable $result might not be defined. ------ -------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------ Line pareview_temp/modules/phpstan_tests/src/Form/PhpstanTestsRunTestsMultistepForm.php ------ ------------------------------------------------------------------------------------ 381 Variable $types might not be defined. ------ ------------------------------------------------------------------------------------ ------ -------------------------------------------------------- Line pareview_temp/src/Controller/CustomTestsController.php ------ -------------------------------------------------------- 298 Variable $filter_where might not be defined. ------ -------------------------------------------------------- ------ --------------------------------------------------------------------------------- Line pareview_temp/tests_module/custom_tests/src/CustomTSTests/CheckFor404Errors.php ------ --------------------------------------------------------------------------------- 69 \Drupal calls should be avoided in classes, use dependency injection instead ------ --------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------- Line pareview_temp/tests_module/custom_tests/src/CustomTSTests/CheckForLibrariesModule.php ------ --------------------------------------------------------------------------------------- 69 \Drupal calls should be avoided in classes, use dependency injection instead ------ --------------------------------------------------------------------------------------- [ERROR] Found 33 errors- Your README.md does not follow best practices (headings need to be uppercase). See
https://www.drupal.org/node/2181737 →
.
As you can see, there is quite a lot to work on. I recommend getting your dev environment and IDE set up with PHPCS, so that you see issues as you type.
I also would recommend adding a .gitlab-ci.yml file → , so that in the future every time you push changes they will be automatically validated.
I'm also a bit concerned that despite this module providing a way to run PHPCS and other code quality checking tools, this module's code doesn't seem to have been run by them and doesn't meet Drupal coding standards. That's why I recommend that the module maintainer spend some time getting GitLab integration set up and working to get the IDE PHPCS integration.
While we can provide a list of items to fix, if you're only fixing them based on what we put in the comments, that doesn't guarantee that issues won't be reintroduced in future commits, without getting found or fixed.
- Status changed to Needs review
7 months ago 7:43pm 6 June 2024 - 🇺🇸United States trigve hagen Washington DC
Fixed all PHPCs and PHPStan to level 1 issues. Will continue to work on them. \Drupal::installProfile() is used this way in all contrib modules that use it.
- Status changed to Needs work
7 months ago 8:13pm 6 June 2024 Many of the PHPCS errors from above are still not fixed. Please set up and configure PHPCS properly.
vendor/bin/phpcs --standard=Drupal,DrupalPractice --ignore=vendor --extensions=php,inc,module,install,info,test,profile,theme --parallel=2 ./Or use this phpcs.xml.dist:
<?xml version="1.0" encoding="UTF-8"
Default PHP CodeSniffer configuration for Drupal project.
?>
Consider using DDEV and DDEV Drupal Contrib for module development, as it makes running PHPCS and PHPStan super easy. Using it I can pull your project's code and run everything on it in under a minute. You can also run
ddev phpcbfand have it auto-fix the mistakes.- Status changed to Needs review
6 months ago 12:04pm 7 June 2024 - 🇺🇸United States trigve hagen Washington DC
Finished and corrected the phpcs errors and statement. Thanks.
- 🇮🇳India vishal.kadam Mumbai
I am changing priority as per Issue priorities → .
- 🇮🇳India vishal.kadam Mumbai
I am changing priority as per Issue priorities → .
- 🇺🇸United States trigve hagen Washington DC
I'm moving list packages module out of this module into its own module. Might as well wait till I finish the move. Thanks.
- 🇺🇸United States trigve hagen Washington DC
The move is finished and Testsuite is ready for review. Thanks
- Assigned to apaderno
- Status changed to RTBC
4 months ago 2:16am 4 September 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
- Dries → ' post on Responsible maintainers
- Maintainership →
- Git version control system →
- Issue procedures and etiquette →
- Maintaining and responding to issues for a project →
- Release naming conventions → .
You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank the dedicated reviewers as well.
- Status changed to Fixed
4 months ago 2:16am 4 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.