🇺🇸United States @trigve hagen

Created a module that allows you to run small fixes including this one from the admin Module Cleanup @ https://www.drupal.org/project/module_cleanup → . Thanks!

Created a module that allows you to run small fixes including this one from the admin Module Cleanup @ https://www.drupal.org/project/module_cleanup → . Thanks!

Created a module that allows you to run small fixes including this one from the admin Module Cleanup → . Thanks!

What about adding this as a permanent fixture to the database so that the field could be used to check for unauthorized changes to content? I have a use case for this and the idea would be to have a page where an admin could run checks by creating a hash and then comparing it to the entity revision hash that gets saved on creation.

trigve hagen → created an issue.

Drupal 10, php 8.1. Your right older versions. Thanks.

trigve hagen → created an issue.

Many Thanks!

The move is finished and Testsuite is ready for review. Thanks

I'm moving list packages module out of this module into its own module. Might as well wait till I finish the move. Thanks.

I work developing and switching between branch causes this to happen often so I created a module to fix this. https://www.drupal.org/project/module_cleanup →
Hope your doing well!

Thanks

No problem thanks.

Not sure whats the problem? I got rid of all references.

This fixed mine.

Sure thing Thank you!

Fixed in release 3.0.72-beta1

Fixed in release 3.0.72-beta1

Created a patch to fix the error.

Trigve Hagen → created an issue.

Finished and corrected the phpcs errors and statement. Thanks.

Fixed all PHPCs and PHPStan to level 1 issues. Will continue to work on them. \Drupal::installProfile() is used this way in all contrib modules that use it.

Made changes for the next release.

Ned Review!

Needs Review

Added a fix for the regex in all calls that passed parameters to the getData function. Added the ^ at the beginning and the $ at the end. Updated the getData function with the escapeshellcmd() function. Will also add escapeshellarg() to all parameters. Also did some repairs to the phpunit_tests Functional phpunit test and report table. Ill have the escapeshellarg() to all parameters done by the end of the weekend. I will also spend some time testing this weekend to confirm the changes are working properly.

cmlara, Can you please get a hold of me to fix this. I have been waiting for your response. I'm willing to do whatever we need to fix this. Thanks

Ive finished work on the dev branch @ composer require 'drupal/testsuite:3.0.x-dev@dev'. Should I make a release or wait for you to validate the code base? I didn't realize I could wait before or I would have. Thanks.

At this website you can find a list of known software that have had security vulnerabilities. We are all in a state of constant development working to secure our code. Composer has one. I'm going to use this API in creating a vulnerability scan for software package too in the testsuite.
Government vulnerability API Source

CVE-2024-24821 - Composer is a dependency Manager for the PHP language. In affected versions several files within the local working directory are included during the invocation of Composer and in the context of the executing user. As such, under certain conditions... read CVE-2024-24821
Published: February 08, 2024; 7:15:08 PM -0500

Ive been doing an extensive remodel on this project that will be done in a couple of days. Adding phpcs and phpstan alongside phpunit. Also building all three as report pages with filter forms. Also adding databases for each one. There is no use leaving this in this category for now. Moving to needs work. Thanks.

I was in a rush to get this done for work. I overlooked that detail in hast. Definitely will slow down a bit so as not to repeat this. Thanks.

define('DRUPAL_ROOT', getcwd()); If you look at DRUPAL_ROOT it is defined by the function getcwd().

Ready again.

Updated code to use DIRECTORY_SEPARATOR. Finished 2 more reviews. Thanks.

Good clean code, a clear README, Coder returns 1 warning but its - File appears to be minified and cannot be processed about the build file don't think this matters, chime in if I'm wrong. PARreview looks good. Thanks. Sending it to RTBC if no one objects.

Needs Work

Code looks good but I found these errors. You don't have a LICENSE.txt.

FILE: /var/www/html/global/web/modules/contrib/error_reporting/libraries/js/error_reporting.js
-------------------------------------------------------------------------------------------------
FOUND 27 ERRORS AFFECTING 12 LINES
-------------------------------------------------------------------------------------------------
2 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
13 | ERROR | [x] Expected 1 space before "<"; 0 found
13 | ERROR | [x] Expected 1 space after "<"; 0 found
13 | ERROR | [x] Expected 1 space before "="; 0 found
13 | ERROR | [x] Expected 1 space after "="; 0 found
13 | ERROR | [x] Expected 1 space before "-"; 0 found
13 | ERROR | [x] Expected 1 space after "-"; 0 found
13 | ERROR | [x] Expected 1 space before "="; 0 found
13 | ERROR | [x] Expected 1 space after "="; 0 found
13 | ERROR | [x] Expected 1 space before ">"; 0 found
13 | ERROR | [x] Expected 1 space after ">"; 0 found
13 | ERROR | [x] Expected 1 space before "<"; 0 found
13 | ERROR | [x] Expected 1 space after "<"; 0 found
13 | ERROR | [x] Expected 1 space before "/"; 0 found
13 | ERROR | [x] Expected 1 space after "/"; 0 found
13 | ERROR | [x] Expected 1 space before ">"; 0 found
13 | ERROR | [x] Expected 1 space after ">"; 0 found
73 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
75 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
79 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
84 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
88 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
97 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
105 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
113 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
118 | ERROR | [x] Whitespace found at end of line
119 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

Time: 9.36 secs; Memory: 10MB

There are a couple of the phpcs error in this file. Code looks good. No duplication of code or functionality that I could see. README.md looks good, No security vulnerabilities that I can see off hand. Moving to Reviewed and tested if no one objects.

FILE: /var/www/html/global/web/modules/contrib/kontainer/js/kontainer.js
---------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------
3 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
7 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
28 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

Time: 3.75 secs; Memory: 12MB

I adjusted the duplicated code. I also adjusted MessengerInterface. And I adjusted the comments. The @file, core modules uses a description of what the module does. Check automated_cron, ban, basic_auth, big_pipe, etc.. Im just following their lead. Thanks for the review.

If these are just suggestions I would like to keep my code as is. Thanks.

Reviewed other applications.

Since he is passing you to needs review if no one objects your good with me.

Good code, a clear README, Coder returns a couple errors in the phpunit test, PARreview looks good. I didn't see any noticeable security vulnerabilities. Get these last things fixed so I can get you pushed to RTBC. Thanks

FILE: /var/www/html/global/web/modules/contrib/time_clock/src/Form/TimeClockForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/global/web/modules/contrib/time_clock/src/Plugin/Block/TimeClockBlock.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/global/web/modules/contrib/time_clock/js/timezone.js
---------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
8 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
8 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
21 | ERROR | [x] Space before opening parenthesis of function call prohibited
21 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

Time: 2.93 secs; Memory: 10MB

Good code, a clear README, Coder returns 2 errors in the phpunit test, PARreview looks good. I would suggest being more descriptive in the help so people better understand what the module does. I didn't see any noticeable security vulnerabilities. Since apaderno seems to be ok with your code Im going to push this to RTBC. Thanks

FILE: /var/www/html/global/web/modules/contrib/field_extra/tests/src/Functional/FieldExtraTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
79 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

Time: 4.86 secs; Memory: 10MB

Ok. Sounded by RTBC that we tested the code too to make sure it works. So we do not test the code? If that's the case I would set the code to RTBC unless you object. Thanks.

Good clean code, a clear README, Coder returns 0 errors, PARreview looks good.
I just need to test your code out. Is there a way that we could team meet and you can walk through the installation and set up? I do not have a school or business email that I can set up a Microsoft Power BI account with. Then I can mark you as RTBC. Thanks.

Thanks. Will do.

Anybody There?

Ready for Review. Thanks. Do I need to do anything else?

I realy need this for work on a .gov site. Thanks

Fixed it Thanks.

I need it reviewed Please.

Figured out there was a left over ga_login plugin that needed to be removed. As soon as it was removed the composer started downloading the right package. So following the readme in ga_login fixes this issue.

Needs Review. Thanks.

https://www.drupal.org/project/drupal/issues/3135247 →
Is this the reason?

Ready for review.

Its fixed. Thanks

Ive finished the security fixed and I'm ready for review again. Thanks

Trigve Hagen → created an issue.

Search for paragraph in your database. It will be a left over in your key_value table. At least it was for me.

SELECT * FROM `drupal10`.`key_value` WHERE (CONVERT(`collection` USING utf8) LIKE '%paragraph%' OR CONVERT(`name` USING utf8) LIKE '%paragraph%' OR CONVERT(`value` USING utf8) LIKE '%paragraph%')

You may need to have HAL installed. That fixed mine.

Trigve Hagen → created an issue.

Trigve Hagen → created an issue.

Thanks

Just fixed it Ready.

Got them fixed. Should be ready now.

Hey buddy. I finished up the tasks. Hows it look? Thanks

Awesome thanks!

Hey thanks for the input on this. Can you please tell me how you configures phpcs and phpcbf because after installing and setting it all up I get conflicting reports between VScode terminal and the intel in the editor itself. When the editor reports it is good(No errors) the terminal reports a ton of errors and visa versa. I need to get this going for work. I work for the Gov @ Department of the Inspector General and this is for work. I looked over other plugins in contrib and all of them are failing. Is this something new you are implementing? Thanks.