Dialog close icon not reliably visible in forced colors mode

Issue created by @bnjmnm
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
29,882 pass
@bnjmnm opened merge request.
Issue was unassigned.
Status changed to Needs review about 1 year ago6:06pm 26 July 2023
Comment about 1 year ago →
🇺🇸United States bnjmnm Ann Arbor, MI
Solution in MR. Forced colors background SVG uses buttonText system color as BG color, so it is visible regardless of the forced color scheme.
Status changed to RTBC about 1 year ago2:44pm 27 July 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Verified the issue using a dark mode extension on chrome (allows to select light mode also)
MR seems to resolve the issue.
Comment about 1 year ago →
System Message

lauriii → committed 9947041b on 11.x
Issue #3377207 by bnjmnm, smustgrave: Dialog close icon not reliably...
Comment about 1 year ago →
System Message

lauriii → committed 35d5e6f9 on 10.1.x
Issue #3377207 by bnjmnm, smustgrave: Dialog close icon not reliably...
Comment about 1 year ago →
🇫🇮Finland lauriii Finland
Committed 9947041 and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!
Status changed to Fixed about 1 year ago5:36pm 27 July 2023
Comment about 1 year ago →
System Message
lauriii → closed merge request !4482
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Comments & Activities