- Issue created by @lyalyuk
- First commit to issue fork.
- @stovak opened merge request.
- Status changed to Needs work
about 1 year ago 9:40am 3 September 2023 - 🇺🇸United States SocialNicheGuru
So 1.1.+ only supports Drupal 10.
From your patch it looks like it support 8, 9,10.
Should the numbering be for the version be 1.0,7 instead of 1.1.3 ?
- 🇺🇸United States stovak Los Angeles
not done with the fix yet. My branch still doesn't work.
- 🇺🇦Ukraine lyalyuk
Done in https://github.com/lyalyuk/social_auth_apple
to install it exclude "drupal/social_auth_apple" in composer:
"repositories": { "drupal": { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": ["drupal/social_auth_apple"] }, "social_auth_apple": { "type": "package", "package": { "name": "drupal/social_auth_apple", "version": "dev-master", "type": "drupal-module", "source": { "url": "https://github.com/lyalyuk/social_auth_apple.git", "type": "git", "reference": "dev-4.0.x" } } } },
- 🇺🇸United States stovak Los Angeles
@lyalyuk if you want to take over this issue and merge yours, have at it. The is a passion project for me and I'm swamped at my day job.
- 🇺🇸United States stovak Los Angeles
Plus the fact that I hate the way Drupal issue branches work (or don't).
- 🇺🇸United States smokris Athens, Ohio, USA
@lyalyuk, thanks for sharing this. I was able to get it working on a Drupal 10.1 site with the following changes:
- In
services.yml
, setparameters
›session.storage.options
›cookie_samesite: None
(without that change, when Apple performs a POST request to the authorization callback, the browser doesn't include Drupal's session cookie, so the state can't be validated) - Apply patch https://github.com/patrickbussmann/oauth2-apple/pull/50
- Apply patch https://github.com/lyalyuk/social_auth_apple/pull/1
- Apply patch https://www.drupal.org/project/social_auth/issues/3399227 ✨ Support networks that POST to the authorization callback Needs review
- In
- 🇨🇭Switzerland ayalon
How should we proceed with this? I'm unsure how we can get to a stable version within the module.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 10:42am 28 March 2024 I added a new version of a module that is used on my sites to the merge request (2.x branch).
This version is compatible with version 4 of Social Auth; to work, you also need to install a patch for the patrickbussmann/oauth2-apple library from here https://github.com/patrickbussmann/oauth2-apple/pull/47 (patch). I would be glad if someone joins in solving the problem in the library.
composer.json is written according to the template from here → .
README.md is written according to the template from here → .
GitLab CI/CD is also configured.Minimum requirements for Drupal ^9.5 || ^10, and the minimum PHP version is 8.0.
I suggest posting it as a separate alpha version 2.0 to start distributing and adding information about installing the patch as a reference to this version of the module on the module page.
and adding information about installing the patch as a reference to this version of the module on the module page.
The library bug "patrickbussmann/oauth2-apple" has been fixed, so you don't have to worry about patches
- Status changed to Fixed
5 months ago 9:03am 17 June 2024 - 🇨🇭Switzerland ayalon
Thanks for all the work done here. I have created a new 2.x branch with the changes from kksandr .
Sorry that it took so long, I did not see the mail notification I got from drupal.org.
- Status changed to Fixed
5 months ago 9:03am 17 June 2024