WorkspacePublishForm $redirectDestination parameter appears not to be used

I think it's possible this could have been caught with an extension to the coverage of Workspaces.

The best location for an extension of tests for '/admin/config/workflow/workspaces/manage/{workspace}/publish' and '/admin/config/workflow/workspaces/manage/{source_workspace}/{target_workspace}/merge' may be Drupal\Tests\workspaces\Functional\WorkspacePermissionsTest

I've added a test for the publish content of a workflow which exposes the bug at least for the publish form.

So the test-only MR fails but the tests weren't added to the main MR (4448) to see if they would pass. Can you add those please.

I've added the test to the main MR. Apologies.

Confirmed the bug in the IS
MR 4448 solves the issue.
4449 shows the test case is showing the problem.

The changes done in 📌 Inject redirect.destination service instead of using \Drupal:: destination() in non-tests Fixed were incorrect for the workspace merge and publish forms. They are using RedirectDestinationTrait so that issue should have used $this->getDestinationArray() instead of trying to inject the redirect destination service. Let's correct that properly in this issue :)

Confirmed the bug through manual testing

Left a review, couple of minor optimisations, fine to self RTBC those changes

edit: crosspost with @amateescu

Yes, agree to his suggestions ++

Thanks for the review everyone. I have addressed the feedback from @amateescu.

Looks great now :)

Committed 917678c and pushed to 11.x. Thanks!

Backported to 10.1.x as this is a fatal in a tagged version in the UI and the risk of disruption is low. Additionally, workspaces is still experimental.

I unpublished the old change record.

Automatically closed - issue fixed for 2 weeks with no activity.