core/yarn.lock out-of-sync after [#3374664]

Very unsure what's going on with 10.1.x. Doing the above doesn't give me a changed yarn.lock locally, nor does the CI log show the last line which 11.x shows, which indicates the yarn.lock is out-of-sync:

00:02:11.080 yarn install v1.22.19
00:02:11.147 [1/5] Validating package.json...
00:02:11.150 [2/5] Resolving packages...
00:02:11.460 [3/5] Fetching packages...
00:02:19.074 [4/5] Linking dependencies...
00:02:23.010 [5/5] Building fresh packages...
00:02:23.073 success Saved lockfile.

It _does_ however triggers a yarn run build:css --check somewhere...

Sorry didn't catch this before!

Committed/pushed to 11.x, thanks!

It's not clear to me what's going on with 10.1.x - the 11.x patch definitely doesn't apply at least.

Moving to needs review but could go straight to fixed if the answer is no changes to 10.1.x

Wondering why drupalci is not running yarn with —frozen-lockfile 🤔

Wondering why drupalci is not running yarn with —frozen-lockfile 🤔

Stumbled over this when looking into the mentioned yarn check problems.

NOTE: The command yarn check has been historically buggy and undermaintained and, as such, has been deprecated and will be removed in Yarn 2.0. You should use yarn install --check-files instead.

Source: https://classic.yarnpkg.com/lang/en/docs/cli/check/

So wondering why we're using that?

Anyway: Looking at this: https://github.com/yarnpkg/yarn/issues/4147

yarn install —frozen-lockfile would have thrown an error instead of updating the yarn.lock in this case, which is AFAICT exactly what we want (and I personally, as the person opening the above issue, would have expected to be the default behaviour of yarn install in the first place).

Am I right in thinking we need/want a follow-up issue to use yarn install —frozen-lockfile instead of yarn install in core/scripts/dev/commit-code-check.sh?

And to add to the 10.1.x mystery: The latest commit on that branch now _doesn't_ trigger yarn run build:css --check anymore...

So this issue is probably "fixed" now, leaving open for the yarn check and yarn install --frozen-lockfile questions/possible follow-up questions.

OK let's move this back to fixed, I think that's definitely worth a follow-up to use --frozen-lockfile though.

Automatically closed - issue fixed for 2 weeks with no activity.