Duplicate Ids in primary and secondary toolbar

Created on 10 July 2023, over 1 year ago

Problem/Motivation

@gin/navigation/toolbar--gin--secondary.html.twig uses the same tabs and trays values as the primary toolbar. As a result, when both are rendered on the page, ids are duplicated

Steps to reproduce

Proposed resolution

Create a dedicated set of secondary toolbar items with unique ids that are used when @gin/navigation/toolbar--gin--secondary.html.twig sees they are present.

This will require updating that template in the gin project (link on the way...)

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @bnjmnm
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI
  • First commit to issue fork.
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland saschaeggi Zurich

    @bnjmnm can you rebase this MR? ๐Ÿ™‡

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

    Liam Morland โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review 10 months ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada Liam Morland Ontario, CA ๐Ÿ‡จ๐Ÿ‡ฆ

    Rebased

  • Pipeline finished with Success
    10 months ago
    Total: 221s
    #114982
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia anchal_gupta

    I am not able to reproduce this issue in my local.

    Scenerio 1
    Step1: First I unable the gin theme.
    Step2: Then Enable Gin toolbar module.
    Step3: Check Ids in primary and secondary toolbar.

    Scenerio 2
    Step1: First I unable the gin theme.
    Step2: Then Enable Gin toolbar module.
    Step3: Applying the patch.

    Using the both Scenerio but not get the exact issue. please share process to reproduce the issue.
    If i am doing something wrong do let me know the steps or explain the issue with more detail so i can replicate it correctly.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany jurgenhaas Gottmadingen
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany jurgenhaas Gottmadingen

    There are several issue with this:

    • When using MR !28, the order of items in the secondary toolbar changes. This can be reproduced when announcement and/or Commerce Cart is enabled, then the user menu moves from the most right position to the left before the 2 new ones.
    • The items with duplicate IDs are actually used both. For smaller screens, the secondary toolbar disappears and the formerly hidden items become visible.
    • Problem being, either javascript or css may rely on the IDs
    • The secondary toolbar is not here forever. When Drupal core's top toolbar will be stable, it won't be required any longer.

    This needs more work, where we first should find a way on how to handle the duplicate IDs in the context of the responsive requirement.

Production build 0.71.5 2024