- Issue created by @bnjmnm
- Merge request !28Issue #3373687: Duplicate Ids in primary and secondary toolbar โ (Open) created by bnjmnm
- Status changed to Needs review
over 1 year ago 4:45pm 10 July 2023 - First commit to issue fork.
- Status changed to Needs work
about 1 year ago 7:40pm 21 October 2023 - ๐จ๐ญSwitzerland saschaeggi Zurich
@bnjmnm can you rebase this MR? ๐
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Liam Morland โ made their first commit to this issueโs fork.
- Status changed to Needs review
10 months ago 5:05pm 8 March 2024 - ๐ฎ๐ณIndia anchal_gupta
I am not able to reproduce this issue in my local.
Scenerio 1
Step1: First I unable the gin theme.
Step2: Then Enable Gin toolbar module.
Step3: Check Ids in primary and secondary toolbar.Scenerio 2
Step1: First I unable the gin theme.
Step2: Then Enable Gin toolbar module.
Step3: Applying the patch.Using the both Scenerio but not get the exact issue. please share process to reproduce the issue.
If i am doing something wrong do let me know the steps or explain the issue with more detail so i can replicate it correctly. - ๐ฉ๐ชGermany jurgenhaas Gottmadingen
There are several issue with this:
- When using MR !28, the order of items in the secondary toolbar changes. This can be reproduced when announcement and/or Commerce Cart is enabled, then the user menu moves from the most right position to the left before the 2 new ones.
- The items with duplicate IDs are actually used both. For smaller screens, the secondary toolbar disappears and the formerly hidden items become visible.
- Problem being, either javascript or css may rely on the IDs
- The secondary toolbar is not here forever. When Drupal core's top toolbar will be stable, it won't be required any longer.
This needs more work, where we first should find a way on how to handle the duplicate IDs in the context of the responsive requirement.