- Issue created by @bgreco
- Status changed to Needs review
almost 2 years ago 2:05pm 10 July 2023 - last update
almost 2 years ago 29,807 pass - @smustgrave opened merge request.
- Status changed to RTBC
almost 2 years ago 3:44pm 11 July 2023 - 🇺🇸United States smustgrave
@bgreco if you have to open the MR if you want to be reviewed
Tests fail with Failed asserting that actual size 3 matches expected size 0. without the fix.
Think this is good for committer review.
- last update
almost 2 years ago 29,811 pass - last update
almost 2 years ago 29,815 pass - last update
almost 2 years ago 29,815 pass - last update
almost 2 years ago 29,822 pass - last update
almost 2 years ago 29,842 pass - last update
almost 2 years ago 29,878 pass - last update
almost 2 years ago 29,881 pass - last update
almost 2 years ago 29,885 pass - last update
almost 2 years ago 29,905 pass, 3 fail - last update
almost 2 years ago 29,911 pass - last update
almost 2 years ago 29,946 pass 58:39 57:25 Running- last update
almost 2 years ago 29,953 pass - last update
almost 2 years ago 29,958 pass - last update
almost 2 years ago 29,958 pass - Status changed to Needs work
almost 2 years ago 7:21am 12 August 2023 - 🇳🇿New Zealand quietone
I am doing triage on the core RTBC queue → .
I read the issue summary and the comments, noting that there is a proposed resolution but no remaining tasks. Also, there are no unanswered questions.
I wonder if there is an existing issue for this. It seems that this is something others would have run into. Maybe it is just me because I don't see a search for duplicates or related issues.
Is it possible to have steps to reproduce?
I read the code and test, which are both straightforward. However, the test is testing the deletion of database rows but it is not a testing the problem stated in the issue summary. I think that needs to be done before string are deleted. I looked in the functional tests in the locale module and there are some related to updates. I did not look closely but I think that should be explored.
I am setting back to needs work for testing.