- Issue created by @urvashi_vora
- Status changed to RTBC
about 1 year ago 6:45am 30 October 2023 - 🇮🇳India Ashutosh Ahirwal India
Provided patch get applied cleanly.
Moving to RTBC. - Status changed to Needs work
about 1 year ago 7:37am 30 October 2023 - 🇮🇳India chetan 11
./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js /home/valuelabs/projects/newone/web/modules/project/disable_web_install
PHPCBF RESULT SUMMARY
-----------------------------------------------------------------------------------------------------------------------
FILE FIXED REMAINING
-----------------------------------------------------------------------------------------------------------------------
/home/valuelabs/projects/newone/web/modules/project/disable_web_install/disable_web_install.module FAILED TO FIX
-----------------------------------------------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS WERE FIXED IN 1 FILE
-----------------------------------------------------------------------------------------------------------------------
PHPCBF FAILED TO FIX 1 FILEAbove error is not fixed with cbf commandd.
- Status changed to Needs review
about 1 year ago 7:45am 30 October 2023 - 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- 🇵🇭Philippines clarkssquared
Hi
I applied the MR !4 and I confirmed that it fixes the PHPCS issues in the module,
➜ disable_web_install git:(main) ✗ curl https://git.drupalcode.org/project/disable_web_install/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 574 0 574 0 0 1077 0 --:--:-- --:--:-- --:--:-- 1099 patching file disable_web_install.module ➜ disable_web_install git:(main) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml disable_web_install FILE: ...local/web/modules/contrib/disable_web_install/disable_web_install.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- Time: 123ms; Memory: 10MB ➜ contrib git:(main) ✗The warning that my terminal reported occurs when a module is installed via composer.
RTBC +1 from me