- Issue created by @urvashi_vora
- š®š³India Ashutosh Ahirwal India
Provided patch applied cleanly but still throwing error.
Providing updated patch with fixes.Used command
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/search_api_weaviateRemaining issue
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/search_api_weaviate/src/Plugin/search_api/backend/SearchApiWeaviateBackend.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------Time: 166ms; Memory: 12MB
- šµšPhilippines cleavinjosh
Hi @Ashutosh Ahirwal,
I applied patch #2, it was applied smoothly and fixed the phpcs issues.
ā search_api_weaviate git:(1.0.x) curl https://www.drupal.org/files/issues/2023-11-01/phpcs-issue-fixes_1.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6189 100 6189 0 0 15446 0 --:--:-- --:--:-- --:--:-- 15433 patching file search_api_weaviate.module patching file src/Plugin/search_api/backend/SearchApiWeaviateBackend.php ā search_api_weaviate git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml search_api_weaviate ā contrib git:(main) ā
RTBC+1 for me.
Thank you.
- Status changed to Needs work
about 2 months ago 1:45pm 21 July 2024 - šµšPhilippines clarkssquared
HI
I also cloned the module and the dedicated version and applied the patch and confirmed that it fixes PHPCS isses.
ā search_api_weaviate git:(1.0.x) curl https://www.drupal.org/files/issues/2023-11-01/phpcs-issue-fixes_1.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6189 100 6189 0 0 13859 0 --:--:-- --:--:-- --:--:-- 14130 patching file search_api_weaviate.module patching file 'src/Plugin/search_api/backend/SearchApiWeaviateBackend.php' ā search_api_weaviate git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml search_api_weaviate ā contrib git:(main) ā
However, for maintainer's convenience can you create a merge request with your patch so that they can easily merge it once it passes the community? moving this ticket to needs work for that.
- Status changed to Needs review
about 2 months ago 11:43am 23 July 2024 - Status changed to RTBC
about 2 months ago 11:53am 23 July 2024 - š®š³India bhaveshdas
I have tested MR 1 and it is working properly with no errors found.
I will move it forward to RTBC.RTBC+1
Thankyou !!