- Issue created by @indrapatil
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:15am 7 July 2023 - Status changed to Needs work
over 1 year ago 11:54am 7 July 2023 - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 5:26am 28 September 2023 - š®š³India rudrakumar188
By Running
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/webform_simplenews_handler-2.0.1
was able to reproduce error in D10.1 and MR request fixes the error.
Hi @bharath_kondeti,
Applied the changes you committed on MR!3, it was applied not-so successfully, but miraculously, there are no errors reported.
ā webform_simplenews_handler git:(2.0.x) curl https://git.drupalcode.org/project/webform_simplenews_handler/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1805 0 1805 0 0 4388 0 --:--:-- --:--:-- --:--:-- 4467 patching file README.md patching file src/Plugin/WebformHandler/SubmissionSimplenewsWebformHandler.php patching file webform_simplenews_handler.info.yml Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file webform_simplenews_handler.info.yml.rej ā webform_simplenews_handler git:(2.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_simplenews_handler ā contrib git:(master) ā
Will not transition this yet so that others will review it too.
Thanks,
Jake- Status changed to RTBC
4 months ago 3:32pm 15 August 2024 - š®š¹Italy apaderno Brescia, š®š¹
- Merge request !9Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3373142-gitlab-ci-reports to hidden.