Minor phpcs issues

C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig term_condition FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\term_condition\src\Plugin\Condition\Term.php -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\term_condition\term_condition.install ------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 55 | ERROR | [x] Expected 1 space before "="; 0 found 67 | ERROR | [x] Use "elseif" in place of "else if" ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- Time: 829ms; Memory: 6MB

Comments & Activities

Issue created by @sidharth_soman
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
Waiting for branch to pass
@sidharth_soman opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago4:09pm 6 July 2023
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
Comment 8 months ago →
🇮🇳India Yashaswi18
Hello, after checking out to the branch '3372964-minor-phpcs-issues' and running the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig term_condition, I found no errors or warnings remaining.
Status changed to RTBC 8 months ago1:44pm 10 March 2024

Comment 8 months ago →

🇵🇭Philippines clarkssquared

I also confirm that there's no PHPCS issues after applying MR !8

➜  term_condition git:(2.0.x) curl https://git.drupalcode.org/project/term_condition/-/merge_requests/8.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   957    0   957    0     0   1698      0 --:--:-- --:--:-- --:--:--  1718
patching file term_condition.install
➜  term_condition git:(2.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml term_condition  
➜  contrib git:(master) ✗

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities