Claro: Row weight select item overlaps the media field in paragraph field

Created on 6 July 2023, over 1 year ago
Updated 16 September 2024, 2 months ago

Problem/Motivation

Row weight select item overlaps the media field in paragraph field

Steps to reproduce

  1. Add a paragraph type to article content type.
  2. Go and add/edit content in article content type.
  3. In the paragraph field, you will the row weight select list is overlapping the item in left.
  4. Attached screenshot for reference.

Before Patch

After patch


🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Claro 

Last updated 3 days ago

Created by

🇮🇳India gauravvvv Delhi, India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @gauravvvv
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    29,439 pass
  • @gauravvvv opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India gauravvvv Delhi, India

    The spacing appears to be correct in RTL (right-to-left), but there is an issue specifically with LTR (left-to-right) text direction. I have submitted a merge request (MR) with the necessary fix. Please kindly review it.

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    Think after screenshots will be needed.

    But also this reproducible in core? Seems like it could be a paragraphs problem.

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India gauravvvv Delhi, India
  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    Can the MR be updated for 11.x please.

  • last update over 1 year ago
    29,805 pass
  • @gauravvvv opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India gauravvvv Delhi, India
  • Status changed to RTBC over 1 year ago
  • 🇺🇸United States smustgrave

    Going to mark but 50/50 if this should be solved in paragraphs or not.

    Thanks!

  • Status changed to Needs review over 1 year ago
  • 🇫🇮Finland lauriii Finland

    Doesn't the weight still overlap with the media field (at least based on the screenshot)?

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India keshavv India

    I have checked and confirmed that the issue is with the Claro Theme. There is no issue with Olivero Theme.
    MR !4351 Works perfectly.

    Here are the before-patch screenshots.
    Claro Theme

    Olivero theme

    After patching in Claro theme.

    We can go with this MR.

  • Status changed to Needs work over 1 year ago
  • 🇫🇮Finland lauriii Finland

    The change increases table column padding for use cases like field cardinality where it's not desired. Is there a way to reproduce this bug with just core? I'm not sure we should at ship the current solution in core because it regresses the UX in common use cases when paragraphs is not used.

  • 🇮🇳India keshavv India

    I agree with your point, Otherwise, we need to write paragraph-specific CSS. Will try to replicate.

  • 🇮🇳India akashdab

    Cannot reproduce this issue in Drupal 11.x Claro, there seems to be some alignment issue to the weight selection dropdown when admin theme is set to Olivero.

    Paragraph view for Claro:



    Paragraph view for Olivero:

    I also found the steps to recreate the issue unclear, so,

    Steps to reproduce

    1. Install Paragraph module form here .
    2. Enable and install Paragraphs and Paragraphs Type Permissions from Admin --> Extend
    3. Now go to Admin>Structure --> Paragraph types. Add a Paragraph type. Choose a label name. Save and Manage fields.
    4. Select create a new field --> File upload --> Give it a label and select Image type --> Save settings(to get the same paragraph structure with image input as suggested by OP)
    5. To add paragraph type to article content type, go to Structure --> Content types --> Select Manage field operation for Article --> Create a new field --> Select Paragraphs & Continue --> Add a label name, Continue --> Scroll down to Paragraph types, Select the paragraph type you created in Step 3 & save settings
    6. Now go to Admin --> Content --> Add content --> Article to add content in article content type.
  • Followed given steps not able to reproduce alignment issue related to row eight field.

    Drupal Version 11.x-dev
    Paragraphs module version- 8.x-1.18
    Themes- Claro , Olivero
    Steps to reproduce already mentioned in #15.

    Steps followed
    1. Created Paragrpahy Type, added fields to it.
    2. Add a paragraph type to article content type.
    3. Add/edit content in article content type.
    4. Check for Olivero and Clro theme.

Production build 0.71.5 2024