- Issue created by @roshni27
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:42am 5 July 2023 - Status changed to Needs work
over 1 year ago 8:49am 6 July 2023 @roshni27 , after applying the patch getting this ->
FILE: C:\xampp\htdocs\project\modules\contrib\site_branding_per_role\site_branding_per_role.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------FILE: C:\xampp\htdocs\project\modules\contrib\site_branding_per_role\src\Plugin\Block\SiteBrandingPerRoleBlock.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------Time: 237ms; Memory: 10MB
- Assigned to nitin_lama
- Status changed to Needs review
over 1 year ago 10:13am 6 July 2023 - š®š³India roshni27
@tanuja Make sure you are checking the '3372442-fix-the-issues' branch where the MR is created. I did not getting any warnings.
- š®š¹Italy apaderno Brescia, š®š¹
The content of the .info.yml file is the following.
name: 'Site Branding Per Role' type: module description: 'Site branding configuation per role.' core_version_requirement: ^8 || ^9 || ^10 package: 'Site Branding'
It cannot cause the warnings/errors reported in the previous comment.
- Issue was unassigned.
- Status changed to RTBC
3 months ago 1:22am 20 August 2024 Hi @everyone,
Also reviewed MR!4 and confirmed no errors remaining.
site_branding_per_role git:(2.x) curl https://git.drupalcode.org/project/site_branding_per_role/-/merge_requests/4.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1338 0 1338 0 0 3275 0 --:--:-- --:--:-- --:--:-- 3345 patching file src/Plugin/Block/SiteBrandingPerRoleBlock.php ā site_branding_per_role git:(2.x) ā . .: not enough arguments ā site_branding_per_role git:(2.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig site_branding_per_role ā contrib git:(master) ā
Will now move this to RTBC.
Thanks,
Jake