Fix dependencies of taxonomy term translation migrations

The first step was to add a skip_on_empty if the content language settings existed.

The last submitted patch, 2: 3371869-2-fail.patch, failed testing. View results →

So, that proves that the new pipeline works.

Then add an optional dependency on d7_entity_translation_settings d7_language_content_taxonomy_vocabulary_settings.yml so that it runs first. And then add a dependency on d7_language_content_taxonomy_vocabulary_settings to the taxonomy term translation migrations.

The changes to drupalci and the test are not needed, that leaves a patch with changes to a 4 migrations.

Think the fail patch does a good job showing the problem.

So the change looks good to me.

I triaged this RTBC issue → sometime in the last weeks but didn't leave a comment.

I didn't find anything that needed to be done.

Leaving at RTBC

The last submitted patch, 4: 3371869-4.patch, failed testing. View results →

Rerunning tests but believe to be unrelated.

The last submitted patch, 4: 3371869-4.patch, failed testing. View results →

Rerunning believe to be unrelated

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Think this one was simple enough and clear which patch to use. Going to remark it.

The patch in #4 was failing and I tracked it to 🐛 Fix MigrateTestBase::executeMigrations() to execute migrations in dependency order Fixed . That issue ensures that the migrations will be ordered by dependency before execution. This resulted in the following error.

1) Drupal\Tests\node\Kernel\Migrate\d7\MigrateNodeTest::testNode
'language_content_settings' entity with ID 'node.et' already exists. (/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:519)
Failed asserting that two strings are equal.

This is happening because 'language_content_settings' was being run last in that group. It needs to be before any translation migration and other 'language_content_settings' ones. The change was to add a dependency to d7_language_content_taxonomy_vocabulary_settings.yml so that it runs after d7_language_content_settings, if it exists.

Random nightwatch failure

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.