- Issue created by @vishal365365
- Status changed to Needs review
12 months ago 9:17am 28 June 2023 - Issue was unassigned.
- Status changed to Needs work
4 months ago 1:25pm 18 February 2024 - ๐ต๐ญPhilippines clarkssquared
Hi
I tested patch #3 and I can also confirm that the patch doesnt apply properly, this is what my terminal is showing:
โ external_entities_field_processors git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-28/3370908-3-fix-issue-reported-by-phpcs.patch | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1648 100 1648 0 0 5623 0 --:--:-- --:--:-- --:--:-- 5762 Checking patch src/FieldMapProcessor/FieldMapProcessorInterface.php... Checking patch src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php... error: while searching for: namespace Drupal\external_entities_field_processors\Plugin\ExternalEntities\FieldMapper; use Drupal\Core\TypedData\PrimitiveInterface; use Drupal\external_entities_field_processors\FieldMapProcessor\FieldMapProcessorManager; use Drupal\Core\Field\FieldDefinitionInterface; use Drupal\Core\Form\FormStateInterface; use Drupal\external_entities\Plugin\ExternalEntities\FieldMapper\SimpleFieldMapper; use Symfony\Component\DependencyInjection\ContainerInterface; /** error: patch failed: src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php:2 error: src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php: patch does not apply โ external_entities_field_processors git:(1.0.x)
- Status changed to Needs review
4 months ago 4:00am 19 February 2024 - ๐ฎ๐ณIndia Preethy_ray
pray_12 โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Preethy_ray
Hi,
Applied the above patch #8, found no Phpcs errors and warning.
Thank you!!