fix issue reported by phpcs

Created on 28 June 2023, 12 months ago
Updated 19 February 2024, 4 months ago

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml external_entities_field_processors/

FILE: external_entities_field_processors/src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface.
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

FILE: external_entities_field_processors/src/FieldMapProcessor/FieldMapProcessorInterface.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityFieldManagerInterface.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------

๐Ÿ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal365365

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @vishal365365
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal365365

    issues fixed

  • Status changed to Needs review 12 months ago
  • Issue was unassigned.
  • ๐Ÿ‡ท๐Ÿ‡บRussia zniki.ru
  • Hi, Reviewed the patch #3, Doesn't apply cleanly,shows error.

  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines clarkssquared

    Hi

    I tested patch #3 and I can also confirm that the patch doesnt apply properly, this is what my terminal is showing:

    โžœ  external_entities_field_processors git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-28/3370908-3-fix-issue-reported-by-phpcs.patch | git apply -v
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  1648  100  1648    0     0   5623      0 --:--:-- --:--:-- --:--:--  5762
    Checking patch src/FieldMapProcessor/FieldMapProcessorInterface.php...
    Checking patch src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php...
    error: while searching for:
    
    namespace Drupal\external_entities_field_processors\Plugin\ExternalEntities\FieldMapper;
    
    use Drupal\Core\TypedData\PrimitiveInterface;
    use Drupal\external_entities_field_processors\FieldMapProcessor\FieldMapProcessorManager;
    use Drupal\Core\Field\FieldDefinitionInterface;
    use Drupal\Core\Form\FormStateInterface;
    use Drupal\external_entities\Plugin\ExternalEntities\FieldMapper\SimpleFieldMapper;
    use Symfony\Component\DependencyInjection\ContainerInterface;
    
    /**
    
    error: patch failed: src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php:2
    error: src/Plugin/ExternalEntities/FieldMapper/FieldMapProcessorsMapper.php: patch does not apply
    โžœ  external_entities_field_processors git:(1.0.x) 
    
  • Status changed to Needs review 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia chaitanyadessai

    Please review patch.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Preethy_ray

    pray_12 โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Preethy_ray

    Hi,
    Applied the above patch #8, found no Phpcs errors and warning.
    Thank you!!

Production build 0.69.0 2024