- Issue created by @sonam_sharma
- Status changed to Needs work
over 1 year ago 8:48am 3 July 2023 - š®š¹Italy apaderno Brescia, š®š¹
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
(Also, change the code to follow the coding standards is a task, not a bug fix.)
- Status changed to Needs review
over 1 year ago 7:22am 6 July 2023 - Status changed to Needs work
5 months ago 5:39am 6 June 2024 Hi @sonam_sharma,
Applied your patch successfully, however it threw one warning.
aimodels git:(main) curl https://www.drupal.org/files/issues/2023-06-27/3370534.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 763 100 763 0 0 3140 0 --:--:-- --:--:-- --:--:-- 3260 patching file aimodels.info.yml patching file aimodels.module ā aimodels git:(main) ā cd .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig aimodels FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/aimodels/aimodels.module ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 18 | WARNING | Code after the RETURN statement on line 16 cannot be executed ------------------------------------------------------------------------------------------------- Time: 104ms; Memory: 10MB
Kindly check.
Thanks,
Jake- Status changed to Closed: works as designed
5 months ago 7:09am 6 June 2024