- Issue created by @fromme
- 🇩🇪Germany rupl
I've also run into this at work, but I didn't actually want the icons and just disabled them temporarily. Either way, we shouldn't output invalid markup. Marking this as a bug.
- 🇩🇪Germany Anybody Porta Westfalica
Could someone please prepare a MR with a fix?
- First commit to issue fork.
- Status changed to Needs work
about 1 year ago 10:53am 25 July 2023 - Merge request !91Replace "device-width" with "width" and "device-height" with "height" in pwa_extras.module. → (Merged) created by fromme
- last update
10 months ago 11 pass - last update
10 months ago 11 pass - Status changed to Needs review
10 months ago 1:20pm 29 November 2023 Replaced "device-width" with "width" and "device-height" with "height" in pwa_extras.module according new info from https://drafts.csswg.org/mediaqueries/#mf-deprecated
"-webkit-device-pixel-ratio" doesn't have any effect, so it wasn't chenged.
Open MR.- Status changed to RTBC
10 months ago 1:22pm 29 November 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thanks @fromme, changes LGTM according to the docs!
I will leave this unmerged for sign off and merge by another maintainer finally.
- Status changed to Fixed
8 months ago 12:22pm 22 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.