Welcome aboard!
Do you think we can get away with universally adding defer?
Adding it universally would be possible and I'd personally like that, but it creates a chance that some very quick bounces aren't counted. Some folks would undoubtedly find it undesirable.
Is the local caching necessary to achieve this? this is a feature I'd really want to avoid.
Yes, using the <script defer> requires an external JS reference (using the src attribute). So the module would have to write JS to the files dir during cache rebuild or cron. If that's a deal-breaker then I'll go ahead and close the issue.
Thanks for the response!
I'm not a maintainer but I helped with the module in the past. The reason there's no activity is described in #3277920: D9 version? → .
We replicated the relevant part from the upstream library's README into the Drupal project page, which I now see is archived. That means it won't get any more updates and they don't think it's worth it to continue development or even bug fixes.
+1 RTBC
This module has been running on a Prod D10 site at my work with zero problems.
Like the other issue, if the W3 validator considers something an error, I consider it a bug 👍🏼
I've also run into this at work, but I didn't actually want the icons and just disabled them temporarily. Either way, we shouldn't output invalid markup. Marking this as a bug.
New settings were just applied: 2.x, with "Auto-close referenced issues on default branch" enabled (it was already enabled when I arrived on the config to adjust branch)
Of course, posting a comment was my rubber-ducky :)
So, I only see 8.x-1.x in the list for the repo. Does the branch need to be pushed or am I looking in the wrong place?
I feel like I probably have the perms to change the default branch (I see I'm a maintainer in the GitLab UI at least) but I've never done such a change. Can you please point me to either a docs page or screenshot what I need to do?
Sure we can expand the existing documentation for the relevant hook. I think adding a couple additional commented examples would be helpful:
https://git.drupalcode.org/project/pwa/-/blob/8.x-1.x/pwa.api.php#L108
The reason is a very long issue linked in the first line of this issue summary: #3070058: Document how to specify the orientation parameter via alter hook →
Just chiming in to say that webkit is joining the 2010s, adding Web Push as of iOS 16.4
https://webkit.org/blog/13878/web-push-for-web-apps-on-ios-and-ipados/
Sorry I never did anything with this. I had a weeks-old baby when I assigned myself so I have no idea why I thought I'd get this done :D
Couldn't a decent workaround be the URL alias patterns? The excludes can be wildcarded so it's pretty easy to slap together.
The API file seems fairly populated, but TBH I didn't evaluate whether it reflected the current state of the D8+ module.
https://git.drupalcode.org/project/pwa/-/blob/8.x-1.x/pwa.api.php
I reviewed this issue from top to bottom and still agree with Alex in #5 and my own comments in #13. If I had to draw a skeleton plan up, I'd avoid bikeshedding and commit the additional tags to the "kitchen sink" — leaving the cleanup into logical submodules for a major version bump.
I think for now adding one maintainer is enough. Anyone is free to create MRs or patches so it won't really block any progress. If there's consistent contribution over time then I'm not opposed to another maintainer.
Thanks for all the movement already!
Yes, using the SW for performance gains without deploying the manifest file will avoid any chance of a PWA prompt.
I've never tried it, but it might be possible to use a theme hook to unset the manifest markup from your HTML output: It is set inside pwa_page_attachments: https://git.drupalcode.org/project/pwa/-/blob/8.x-1.x/pwa.module#L37