- 🇩🇪Germany rupl
Sorry I never did anything with this. I had a weeks-old baby when I assigned myself so I have no idea why I thought I'd get this done :D
- 🇩🇪Germany Anybody Porta Westfalica
Ok so someone please should find out what's the status here and if the commits from above made it into 2.x - thanks!
- 🇨🇦Canada ambient.impact Toronto
As far as I can tell, this was committed by looking at the history of
templates/offline.html.twig
. - Status changed to Postponed: needs info
over 1 year ago 4:10pm 4 August 2023 - 🇩🇪Germany Anybody Porta Westfalica
(Non-security) Bug fixes and new features go into 2.x - so could someone please check, if the issue still exists in 2.x or has been fixed already?
Also please ensure there are clear steps to reproduce the issue. Perfect would be to have tests showing the issue exists and will be fixed forever then ;) Thank you! - Status changed to Needs work
over 1 year ago 9:54am 10 August 2023 - 🇩🇪Germany Anybody Porta Westfalica
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil could you perhaps clarify the status here finally?
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: If unsure, @thomas.frobieter can help with the classes and twig. We shouldn't put much effort into this BTW.
- 🇩🇪Germany Grevil
Fixed:
Didn't put too much effort into it, we could also add a bunch of wrapper divs and best-practice module named classes. But this solves the main issue.
Please review!
- Status changed to Needs review
over 1 year ago 2:27pm 11 September 2023 - last update
over 1 year ago 9 pass - @grevil opened merge request.
- last update
over 1 year ago 9 pass - Status changed to Fixed
over 1 year ago 3:36pm 11 September 2023 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.