Fix the issues reported by phpcs

Created on 26 June 2023, about 1 year ago
Updated 6 June 2024, 25 days ago

Fixed the theme file issues.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Prachi6824

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @Prachi6824
  • Assigned to sourabhjain
  • 🇮🇳India sourabhjain

    Let me work on this.

  • @sourabhjain opened merge request.
  • Issue was unassigned.
  • 🇮🇳India sourabhjain

    I have resolved most of the issues but still below are pending.

    sourabhjain@LPT-SOURABH alif_zymphonies_theme % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
    
    FILE: /Users/sourabhjain/www/drupal/themes/contrib/alif_zymphonies_theme/includes/bootstrap/css/bootstrap.min.css
    -----------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    -----------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/sourabhjain/www/drupal/themes/contrib/alif_zymphonies_theme/includes/bootstrap/css/docs.min.css
    ------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/sourabhjain/www/drupal/themes/contrib/alif_zymphonies_theme/includes/fontawesome/css/fontawesome.min.css
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ---------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/sourabhjain/www/drupal/themes/contrib/alif_zymphonies_theme/includes/owl/assets/owl.theme.default.min.css
    ----------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------
     1 | WARNING | File appears to be minified and cannot be processed
    ----------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/sourabhjain/www/drupal/themes/contrib/alif_zymphonies_theme/alif_zymphonies_theme.theme
    -------------------------------------------------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    -------------------------------------------------------------------------------------------------------------------------
     172 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
     172 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
     178 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
     178 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
     184 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
     184 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
     189 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
     189 | ERROR   | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
    -------------------------------------------------------------------------------------------------------------------------
    
    Time: 270ms; Memory: 22MB
  • Assigned to subhashuyadav
  • Assigned to Prachi6824
  • Status changed to Needs review about 1 year ago
  • 🇮🇳India Prachi6824

    Hello,

    I have created a patch to solve all the errors related to phpcs code standard within the .theme file .
    Please review and apply it

  • Assigned to subhashuyadav
  • Status changed to Needs work about 1 year ago
  • 🇮🇳India subhashuyadav Mumbai

    Fixed the theme file issues.

  • Status changed to Needs review about 1 year ago
  • 🇮🇳India subhashuyadav Mumbai

    Missed few changes in the earlier patch...Here is the updated patch

  • Issue was unassigned.
  • Hi @subhashuyadav,

    Your patch is empty, kindly take a look at it.

    Thanks,
    Jake

Production build 0.69.0 2024