use array_diff_key in layout_disable_layout_alter

Thanks @TomSaw, looks good and makes sense :)

Could you please provide this as MR?

Hey @Anybody. have just submitted my 1th Drupal MR.
Hope it's all fine.

Cool, congratulations @TomSaw :)

@Grevil would you mind to have a look?

The last submitted patch, 2: 3369928-use-array_diff_key.patch, failed testing. View results →

Kindly review the patch if it works.

The last submitted patch, 8: 3369928-8.patch, failed testing. View results →

Checking $disabledLayouts for existence was required cause array_flip is not allowed with null.
$disabledLayouts becomes null when layout_disable.settings was not yet created.

Whilst fixing this, another tiny code improvement happened in LayoutDisableForm::buildForm 😄

array_flip is also not required: settings already have layout_ids as key

What the hell is #8 🌱 use array_diff_key in layout_disable_layout_alter Fixed about? Oh well, I will ignore that. Let's have a look!

Changes LGTM!

Makes the code more readable and (probably) faster! Well done!

Also, good luck with "Rollgut" @TomSaw, looks like a really cool product! 👍

Thanks Everybody, I just got 1% better in contributing workflows.

- Thanks for the good wishes @Grevil 😊

Automatically closed - issue fixed for 2 weeks with no activity.