- Issue created by @Project Update Bot
This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
The attached patch adds core version requirement ^10 to the info file. This seems to be working on my D10 site but has NOT been thoroughly tested.
- 🇩🇪Germany zany
There is already a MessengerTrait in QueryPluginBase and TestMessenger can be injected from ViewsXmlBackendTestBase.
The changes should look more like this: - 🇮🇳India Bushra Shaikh
I applied patch #5 got error:
error: patch failed: views_xml_backend.info.yml:2 error: views_xml_backend.info.yml: patch does not apply
- First commit to issue fork.
I've gone through this and incorporated @zany's suggestions and fixed a number of phpcs issues and issues with the tests. The module is working as expected for me but this could use another review.
- 🇩🇪Germany Schoenef Unna
Hi @bspeare, is there a way to include the whole MR as patch somehow? Then I can test it in our site.
Thx a lot!
Andreas - 🇩🇪Germany zany
To get the whole MR as patch use the MR URL (highlighten green) and add .patch or .diff.
E.g. https://git.drupalcode.org/project/views_xml_backend/-/merge_requests/4.... - 🇩🇪Germany Schoenef Unna
The MR (thx a lot @zany) works well for us. In my opinion it can be merged and released.
- 🇩🇪Germany Schoenef Unna
Hi @bspeare, I'm not sure if I can do it, but for you I think it would be possible to get co-ownership of this module following https://www.drupal.org/node/2938367#s-how-to-apply-for-ownership-or-co-m... →
I have the feeling, that the current maintainers are not really active anymore...
- 🇩🇪Germany Schoenef Unna
Alright, I found https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → and try to follow the procedure via https://www.drupal.org/project/views_xml_backend/issues/3478213 💬 Support in Maintenance Active - it wil take a month... fingers crossed, we can make it faster.
- 🇮🇹Italy kris77
Hi guys,
in the project page there is not version for D10.It's right? where can I download 2.0.0-alpha1 version?
Thank you so much for support.
- 🇩🇪Germany zany
The "2.0.0-alpha1" is a tag on the "8.x-1.x" branch. You can download a zip (button "Code") here https://git.drupalcode.org/project/views_xml_backend
Or wait a few weeks, we are in the process of sorting this out. - Status changed to Fixed
17 days ago 11:12am 4 November 2024 - 🇩🇪Germany Schoenef Unna
Alright, I'm now the new "bugs only" maintainer of this project and just released the version 2.0.0. Thx a lot @bspeare for doing the work on it - if you like I can make you a maintainer as well now.
The MR is merged and I'll clean out the old tickets now.
Please reopen this one, if it still does not work for D10.
Best wishes
Andreas Automatically closed - issue fixed for 2 weeks with no activity.