Fix the issues reported by phpcs

Hi @sonam_sharma, thanks and welcome! We appreciate you testing this project, but if you're running automated tests could you please ensure you're making high-value contributions → ? Unsolicited one-line patches are appreciated, but can also be considered "gaming the system".

We appreciate contributions, but we request that you:

1. open an MR → with it instead.
2. Show logs that you're resolving linting issues for the entire project instead of just a single file.

Thanks.

hello @froboy,
I have fixed remaining issues reported by phpcs.
please review the patch

@sonam_sharma thanks, that's closer. please show your work by pasting in the phpcs command that you ran to get those results so we can validate. Also, see item 1 in #3 above - this should be in a Merge Request instead of a patch. Learning the MR process will help you help others even better! Thanks.

@sonam_sharmaI see the merge request open, but it looks like there is no code pushed to the branch.

Now that the issue fork is open, you'll need to use the "Show Commands" link above to connect the branch to your local and commit the changes in the patch. Alternatively, you could use the GitLab Web IDE to spin up a copy of the branch, upload the patch, apply it, and commit it.

Thanks for going through the process with us. Please let me know if you have any questions.

hello @froboy, Updated the patch changes into the merge request. Please review the same.
For verified used this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/openy_carnation

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

tnx

Automatically closed - issue fixed for 2 weeks with no activity.