Fix the warnings/errors reported by PHP_CodeSniffer

Created on 23 June 2023, over 1 year ago
Updated 21 August 2024, 3 months ago
šŸ“Œ Task
Status

Needs work

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sonam_sharma
  • Issue was unassigned.
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

  • Status changed to Needs work 3 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @sonam_sharma,

    I applied patch #2 and it was failed.

    āžœ  restaurant_lite git:(8.x-1.x) curl https://www.drupal.org/files/issues/2023-06-23/3368957.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 13409  100 13409    0     0  38973      0 --:--:-- --:--:-- --:--:-- 38979
    patching file theme-settings.php
    Hunk #1 FAILED at 1.
    1 out of 1 hunk FAILED -- saving rejects to file theme-settings.php.rej
    āžœ  restaurant_lite git:(8.x-1.x) āœ— ..

    Furthermore, I encountered more issues than in the descriptions after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

    I'll be attaching a screenshot for reference since it would be very long if I paste it here.

    Thank you.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's create a merge request, now that patches are no longer tested.
    Also, since GitLab CI is enabled for every project, GitLab CI itself reports any PHP_CodeSniffer error/warning.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    3 months ago
    Total: 3409s
    #260229
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi,

    I fixed phpcs issues that was reported by the GitLab CI as much as I can.

Production build 0.71.5 2024