- Issue created by @vishal365365
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:57am 23 June 2023 - Status changed to Needs work
over 1 year ago 5:38pm 23 June 2023 - 🇵ðŸ‡Philippines clarkssquared
Hi vishal365365
I applied your patch #2 to my local and noticed that there are still PHPCS issues being reported.
Please look at the screenshot attached for your reference
Thank you
- First commit to issue fork.
- 🇮🇳India bharath-kondeti Hyderabad
Addressed all the issues. Please review the patch
- @bharath-kondeti opened merge request.
- Status changed to Needs review
over 1 year ago 4:25am 25 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Status changed to Needs work
over 1 year ago 11:59am 25 June 2023 -
jayprakash01 →
committed 12b3a542 on 1.0.x
Issue #3368876 by bharath-kondeti: Fix the issues reported by phpcs
-
jayprakash01 →
committed 12b3a542 on 1.0.x
- Status changed to Needs review
over 1 year ago 12:17pm 27 June 2023 - 🇮🇳India jayprakash01 New Delhi
The patch has been applied, and the release has been made with a new tag.
- Status changed to Fixed
over 1 year ago 12:53pm 6 July 2023 - 🇮🇳India jayprakash01 New Delhi
This is fixed now. Hence closing this.
Automatically closed - issue fixed for 2 weeks with no activity.