- Issue created by @Prachi6824
- Assigned to Prachi6824
- Status changed to Needs review
over 1 year ago 2:49pm 15 June 2023 - 🇮🇳India Prachi6824
Hello ,
I have created a patch to remove the commented code . Please test it and apply it .
Thank You. - Status changed to RTBC
over 1 year ago 5:13pm 15 June 2023 - 🇵🇭Philippines clarkssquared
Hi prachi6824
I applied your patch #2 and I confirmed that your patch removed the commented-out code in curious_chronicles.theme file
Please look at the screenshot for your reference
Thank you
- 🇮🇳India Prachi6824
@clarkssquared thanks for your screenshot and for reviewing my patch.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
In the curious_chronicles.theme file, there is the following commented out code that needs to be removed. It seems to just provide example values which are not much helpful to understand the code of that theme hook.
// Allow the Attribute Class to deal with adding a css class to this element. // $variables['main_sub_heading'] = 'A PERSONAL BLOG'; // $variables['main_heading'] = 'H'; // $variables['main_span_heading'] = 'ell'; // $variables['main_heading_end'] = 'o'; // $variables['page_desc'] = 'I am a Blogger & Photographer Based in Philippines';
- 🇮🇳India Prachi6824
Thank you @apaderno for giving me the advice .
From next time I'll try to improve my issue summary. - Status changed to Needs work
over 1 year ago 8:58am 19 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
function curious_chronicles_preprocess_page(&$variables) { - - // Allow the Attribute Class to deal with adding a css class to this element.
There is no need to leave an empty line before the first code line in a function. An empty line has been removed, but there is still one.
- First commit to issue fork.
- @kpoornima opened merge request.
- Status changed to Needs review
over 1 year ago 10:34am 19 July 2023 - Status changed to Needs work
over 1 year ago 10:50am 19 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
There is already an issue to fix the warnings/errors reported by PHP_CodeSniffer; let us keep this focused on what reported in the issue summary.
Removing the empty line before the commented out code is correct; changing other lines that are not the commented out ones is off-topic.