- Issue created by @Panchuk
- Assigned to dineshkumarbollu
- @dineshkumarbollu opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:56am 13 June 2023 - Status changed to RTBC
over 1 year ago 9:10am 13 June 2023 - 🇵🇭Philippines clarkssquared
Hi dineshkumarbollu
I applied your MR !35 to my local and confirmed that your patch created information to the module's hook help.
Please look at the screenshot attached for your reference
Thank you.
- Status changed to Needs work
over 1 year ago 10:04am 13 June 2023 - 🇺🇦Ukraine Panchuk Volyn, Lutsk
Hey @dineshkumarbollu, thanks for your contribution to Paragraphs Gridstack.
Your changes look good, except for a few things:
1) Please, take a look at coding standards issues.
2) I don't see hook_help for the paragraphs_gridstack_demo module (submodule of the main module).
3) Your commit message didn't follow the standards. Please, do commit amend and change it to "Issue: #3366381 Implemented hook_help()."Thanks
- Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:59am 13 June 2023 - 🇮🇳India sourabhjain
@panchuk Below are the comments:
1) Please, take a look at coding standards issues.
=> Done2) I don't see hook_help for the paragraphs_gridstack_demo module (submodule of the main module).
=> I can see that its already there. Please let me know if you are expecting somewhere else too. Attaching code for reference in paragraphs_gridstack_demo.module fileif ($route_name == 'help.page.paragraphs_gridstack_demo') { $output = '<h3>' . t('About') . '</h3>'; $output .= '<p>' . t('The Paragraphs Gridstack Demo module provides several <em>Paragraphs types</em> for the <a href=":paragraphs">Paragraphs module</a>, but no separate user interface. For more information, see the <a href=":online">online documentation for the Paragraphs module</a>.', [ ':online' => 'https://www.drupal.org/node/2444881', ':paragraphs' => Url::fromRoute('help.page', ['name' => 'paragraphs'])->toString(), ]) . '</p>'; }
-
Panchuk →
committed f38f117e on 1.0.x authored by
dineshkumarbollu →
Issue #3366381 by dineshkumarbollu, sourabhjain, clarkssquared, Panchuk...
-
Panchuk →
committed f38f117e on 1.0.x authored by
dineshkumarbollu →
- Status changed to Fixed
over 1 year ago 2:05pm 14 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.