Add requirement error if Apache does not have mod_rewrite enabled

Patch file adding the requirement to the image module (where image styles are managed).

If I am understanding things correctly, in /core/modules/system/system.install:109 it says:

    // If the Apache rewrite module is not enabled, Apache version must be >=
    // 2.2.16 because of the FallbackResource directive in the root .htaccess
    // file. Since the Apache version reported by the server is dependent on the
    // ServerTokens setting in httpd.conf, we may not be able to determine if a
    // given config is valid. Thus we are unable to use version_compare() as we
    // need have three possible outcomes: the version of Apache is greater than
    // 2.2.16, is less than 2.2.16, or cannot be determined accurately. In the
    // first case, we encourage the use of mod_rewrite; in the second case, we
    // raise an error regarding the minimum Apache version; in the third case,
    // we raise a warning that the current version of Apache may not be
    // supported.

However, due to security issues from SA-CORE-2013-003 → the ability to have the FallbackResource directive function in the sites/all/files/ directory was disabled, resulting in image styles not being correctly rendered without mod_rewrite.

As a result, the requirements might be better updated in this section of code.

Thoughts?

FIxed patch file

Think we will need test coverage for this also.

Bumped version to latest.
Added patch with tests.

Kindly review and suggest.

updated patch to fix cspell issue for 11.x.

The last submitted patch, 8: 3365639-8.patch, failed testing. View results →

Instead of adding to the dictionary think the text can be updated differently.

Thanks @smustgrave this was what I thought initially, but isnt the cspell should also respect the corectly spelled words... in this case it was "redirections", just wondering.

Updated patch by modifying the description.

Routing seems like a good replacement.

I am not sure about the placement of this requirements check. Currently it is in the image module, which can be uninstalled.

https://www.drupal.org/docs/getting-started/system-requirements/web-serv... →

The Apache 'mod_rewrite' extension is required. It is used for clean URLs.

According to the docs, this seems like a hard requirement, so I am curious if it would not be better to add it to the system module?

We also probably want to deal with the existing check in the system.install, in case we will add this check:

// If the Apache rewrite module is not enabled, Apache version must be >=
....

See: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste...

Based on that description (The Apache 'mod_rewrite' extension is required. It is used for clean URLs.) does sound like system is the better spot. Will leave in review for consensus.

Lets do that and move to system module.