Created on 8 June 2023, almost 2 years ago
Updated 25 October 2023, over 1 year ago

Problem/Motivation

A Drupal 10 release is required.

Proposed resolution

Port module to Drupal 10.

Remaining tasks

  • Update metadata (info): Done!
  • Fix automatic errors: Done!
  • Support new operations ( see comment below) ✨ Drupal 10 release Fixed : Done!
  • Provide an upgrade path: doing

User interface changes

A new operation will be added to the content type edit form.

API changes

Internally module is pretty similar. NodeRevisionAccessCheck class has seen some changes.

However, Drupal <9.3 support is dropped.

Data model changes

In configuration entity a new operation is added.

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India rahul1707

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rahul1707
  • First commit to issue fork.
  • @sakthi_dev opened merge request.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India sakthi_dev

    Please review.

  • Assigned to dineshkumarbollu
  • 🇮🇳India dineshkumarbollu

    vendor/bin/drush upgrade_status:analyze node_authlink
    [notice] Processing /var/www/html/vb9/web/modules/contrib/node_authlink-3365570.

    ================================================================================
    Node Authorize Link, --
    Scanned on Thu, 06/08/2023 - 16:17

    FILE:
    web/modules/contrib/node_authlink-3365570/src/Form/NodeAuthlinkNodeForm.php

    STATUS LINE MESSAGE
    --------------------------------------------------------------------------------
    Check manually 91 Relying on entity queries to check access by default is
    deprecated in drupal:9.2.0 and an error will be thrown from
    drupal:10.0.0. Call
    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
    TRUE or FALSE to specify whether access should be checked.
    --------------------------------------------------------------------------------

  • Issue was unassigned.
  • Assigned to rahul1707
  • 🇮🇳India rahul1707

    MR !3 makes module D10 compatible and solves upgrade status problems, however it is throwing below error while installation.

    Symfony\Component\DependencyInjection\Exception\RuntimeException: Service "access_check.node.revision.decorate": Parent definition "access_check.node.revision" does not exist.

    Created a patch to resolve above issue. Kindly review.

  • Status changed to RTBC almost 2 years ago
  • 🇮🇳India Bushra Shaikh

    I have reviewed and checked the patch#8 this works for Drupal 9.5 and Drupal 10.0. and 10.0.1
    Screenshots of the compatibility on 9.5 have been attached for reference:

    can be moved to RTBC+1

  • Status changed to Needs work over 1 year ago
  • 🇪🇸Spain tunic Madrid

    The port to Drupal 10 is more complex than provided here. The most complex issue is the replacement of the access_check.node.revision use. See this change record: https://www.drupal.org/node/3161210 →

    This replacement comes from https://www.drupal.org/node/3043321 → . There, a new operations are added, including "view revision". Node Authlink needs to support this operation tu keep revision support.

    Also, an upgrade path is required. When configuring the module, you can define which operations to act on per content type. D10 release will have this new operation. Because before the "view" operation covered both "view" and "view revision" in D10 we should edit configuration entities and mark "view revision" if the "view" operation is already checked.

    I'm also updating the issue description.

  • 🇪🇸Spain tunic Madrid
  • Assigned to tunic
  • 🇪🇸Spain tunic Madrid
  • @tunic opened merge request.
  • 🇪🇸Spain tunic Madrid

    I've just releases 2.0.0-alpha1 release, compatible with Drupal 10.

    See release notes.

    Any testing on real sites (well, on their dev environments) are more than welcome.

  • Status changed to Needs review over 1 year ago
  • 🇪🇸Spain tunic Madrid

    Reviews from users are welcome.

  • Status changed to Fixed over 1 year ago
  • 🇨🇦Canada joelpittet Vancouver

    Marking as fixed thanks @tunic

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024