- Issue created by @mherchel
- First commit to issue fork.
- last update
over 1 year ago Build Successful - @dharizza opened merge request.
- Status changed to Needs review
over 1 year ago 9:16pm 7 June 2023 - Status changed to Needs work
over 1 year ago 2:29pm 8 June 2023 - 🇺🇸United States smustgrave
Seems there were some failures in the MR.
Have not yet tested.
- 🇺🇸United States mherchel Gainesville, FL, US
When I test this out, I'm getting
Drupal\sdc\Exception\InvalidComponentException: Unable to find class/interface "url" specified in the prop "url" for the component "olivero:feed-icon". in Drupal\sdc\Component\ComponentValidator->validateDefinition() (line 118 of core/modules/sdc/src/Component/ComponentValidator.php).Going to look into it a bit now (if I have time)
- 🇺🇸United States mherchel Gainesville, FL, US
Just left some comments. In addition, we need to copy over the
feed.pcss.cssfile. Both the pcss.css and css files should also be renamed to whatever the component is (in this case "feed"). - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - 🇺🇸United States mherchel Gainesville, FL, US
Starting to look good! Left some more comments in the MR.
- First commit to issue fork.
- last update
over 1 year ago Build Successful - Status changed to Needs review
over 1 year ago 2:33am 21 June 2023 - Status changed to Postponed
over 1 year ago 3:28pm 21 June 2023 - Status changed to Needs work
over 1 year ago 8:35am 3 September 2023 - 🇷🇸Serbia finnsky
Maybe name this component `icon-text` and make svg icon configurable?
This is component and it planned to be reusable. Even if used in one place only? - 🇷🇸Serbia finnsky
Reworked with this described ^ approach.
Common `icon-link` component with configurable icon.
- Status changed to Needs review
over 1 year ago 9:03am 3 September 2023 - last update
over 1 year ago Custom Commands Failed - Status changed to Postponed
over 1 year ago 9:06am 3 September 2023 - Status changed to Needs review
8 months ago 9:03pm 15 April 2024 - Status changed to Needs work
8 months ago 9:21pm 15 April 2024 - 🇷🇸Serbia finnsky
We need to fix linter and fix schema version in component.yaml
- Status changed to Needs review
8 months ago 4:22am 16 April 2024 - Status changed to Needs work
8 months ago 4:03pm 19 April 2024 - 🇺🇸United States smustgrave
Have not reviewed yet
Appears to have test failures.